There are other side effects of the resolve_symlinks patch/change to acl.
I tried to notify the developers, but maybe I have the wrong folks. Anyway, I think after looking more into what this might have been added to fix, the better solution might be to leave the resolve_symlinks workaround for some nftw bug dealing with invalid/dead symlinks, and just after the error path code, call nftw with the original file/path. This way, the original/correct tree walking is preserved, as well as the fix for some at-this-point-undescribed (in detail) issue with symlinks that nftw chokes on?

Specifically, I'm recommending the following patch--"p" reverts to "file",
since at that point resolve_symlinks has been successful and the code can
continue, but using "file" instead of the first link (which is represented by
"p", if "file" was a symlink).


--- acl-2.2.41.orig/getfacl/getfacl.c   2007-07-25 15:49:57.000000000 -0400
+++ acl-2.2.41/getfacl/getfacl.c        2007-07-25 15:50:22.000000000 -0400
@@ -621,7 +621,7 @@
                fprintf(stderr, "%s: %s: %s\n", progname,
                        xquote(file), strerror(errno));
                __errors++;
-       } else if (nftw(p, __do_print, 0, opt_walk_logical? 0 : FTW_PHYS) < 0) {
+       } else if (nftw(file, __do_print, 0, opt_walk_logical? 0 : FTW_PHYS) < 
0) {
                fprintf(stderr, "%s: %s: %s\n", progname, xquote(file),
                        strerror(errno));
                __errors++;




--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to