Hi,
> >> As it's the most recent, I'll use Martin's patch as a starting point -
> >> Jamey, Josh and Junichi, would applying the patch proposed in
> >> http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=5;att=0;bug=433081
> >> provide you with the functionality you'd expect / want from using
> >> debcommit against git repositories?
> >
> > As I commented, use of '--cached' will make debcommit work differently
> > for 'git' compared to other SCMs; I thought I proposed a patch and
> > made an attachment.
>
> "git commit" behaves differently than other SCMs. If I use debcommit with
> Git, I don't expect consistency with other SCMs; I expect consistency with
> Git. debcommit should always behave like the default commit command of the
> version control system in use.
>
> I believe debcommit should continue using --cached, and simply needs to stop
> using git commit -a.
So, you're proposing the following workflow is better
git-add XXX
git-add YYY
git-status (check what's going to be committed)
git-diff --cached (check the actual diff to be committed)
debcommit
rather than
git-status (check what's going to be committed)
git-diff (check what's to be committed)
debcommit
Of course, neither currently works, so we're only getting better.
However, apparently there are people like you who value the notion of
using the git index file to notify which file to commit. Could you
elaborate why it's so useful? I personally have thought it's one of
the bare metal internals that are accidentally exposed due to the
internal design of git (but I might be biased, I've only been a casual
user of git for the past two years).
Iff using index files is useful; I propose creating the following
three different scenarios, and adopt other SCMs to it. It will change
debcommit behavior on different SCMs.
1. commit what's in git-index (those which have been added with
git-add).
debcommit (without any options)
which will do
git-diff --cached
git-commit
2. commit what's specified on the command-line
debcommit fileA fileB fileC
which will do
git-diff fileA fileB fileC
git-commit fileA fileB fileC
3. commit what's changed (including those which have not been added
with git-add yet).
debcommit -a
which will do
git-diff
git-commit -a
Comments?
This will need modification in the manual, and will have an undecided
behavior for 'debcommit' for other SCMs. I would suggest making
debcommit do nothing, or implicitly do '-a'. Of course, this deviation
will put off some users of other SCMs when they move to git, but of
course, git users are too special.
regards,
junichi
--
[EMAIL PROTECTED],netfort.gr.jp} Debian Project
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
