also sprach Junichi Uekawa <[EMAIL PROTECTED]> [2007.07.18.0210 +0200]: > I had an impression that the code should diff everything as committed, > and find 'debian/changelog'. The effect should be so that, if you > didn't include debian/changelog in your commit, you get an error and > debcommit will barf out. However, it isn't. If you didn't add > debian/changelog explicitly in the command-line you get a commit > without debian/changelog; which is a different 'bug' to the one we're > trying to discuss.
This is not what I see. Initially, I thought the patch should call git add on debian/changelog, but then I decided that it makes more sense to require the user to actually stage that file along with all other hunks. If debian/changelog is not staged, you get the following warning when calling debcommit (with my patch): debcommit: unable to determine commit message using git (did you forget to run git add?) Try using the -m flag. > There are technical people who like that detail, but imo, they can > use git directly. Sure, but debcommit is really a tool to extract the changelog entry and reuse it for the commit message. git can't do that. also sprach Adam D. Barratt <[EMAIL PROTECTED]> [2007.07.18.0814 +0200]: > Other than changing git-diff to "git diff" as per Martin's original > patch, does anyone have any objections to this new version? If not then > I'll look at applying it (or something very close) to the next release. After reading over http://marc.info/?t=118322948500001&r=1&w=2 again, I am not sure it is being deprecated. Let's leave it for now. Thanks, Junichi! -- .''`. martin f. krafft <[EMAIL PROTECTED]> : :' : proud Debian developer, author, administrator, and user `. `'` http://people.debian.org/~madduck - http://debiansystem.info `- Debian - when you have better things to do than fixing systems
signature.asc
Description: Digital signature (GPG/PGP)
