Bug#361568: FTBFS with GCC 4.2: 'scratch' will always evaluate as 'true'

[Jan Christoph Nordholz]

Hi,

this patch just replaces x_strdup() with plain strdup(), which makes the
warning go away without changing the behaviour of the code.
However, the benefits of using -Werror are minimal compared to the number
of possible FTBFS bugs that may surface during compiler transitions...


Regards,

Jan

--- libpam-chroot-0.9/pam_chroot.c	2007-06-28 23:11:45.000000000 +0200
+++ pam_chroot.c	2007-06-28 23:11:18.000000000 +0200
@@ -291,7 +291,7 @@
 		if(NULL == grp) {
 			_pam_log(LOG_DEBUG, "%s: no grnam for gid %d", opts->module, gids[i]);
 			snprintf(scratch, SCRATCH, "%d", gids[i]);
-			groups[i] = x_strdup(scratch);
+			groups[i] = strdup(scratch);
 		} else {
 			groups[i] = x_strdup(grp->gr_name);
 		}

signature.asc
Description: Digital signature