On Tue, May 29, 2007 at 08:58:46PM +0200, Petter Reinholdtsen wrote:
>
> This patch has been tested in Debian Edu a few days now, and seem to
> work as it should. It is available from
> <URL:http://ftp.skolelinux.org/skolelinux/pool/local/c/cpufrequtils/>.
>
> I can NMU this bug into unstable if you, the maintainer, agree with
> the change but is still rather busy. Just let me know.
the idea is definitely worth implementing, just I'd rather make it a
little different (e.g.: no double loading of the defaults file). I'll
implement it shortly, but I'll try to decribe my intent here so that if
I didn't get something from your previous patch you can raise a red
flag.
What we have now is an init-script internally managed ENABLE flag.
So, we may want to:
* change the internal default to 'true'
* load the defaults file if it exists
* if ENABLED == false
exit, we have nothing to do
* else
check for the chosen governor existence
* if GOVERNOR exists
load policy
* else
(optional) print a nice warning about the
unavailability of the governor[1]
[1]: e.g.:
Loading cpufreq policy:... Disabled, governor not available
or
Loading cpufreq policy:... Disabled, user disabled
Also, you don't need to check for the governor for each cpu, afaik you
can't load a kernel governor for just a single cpu.
Thoughts?
--
mattia
:wq!
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
