[Mattia Dongili]
> Hi, the following patch is what I'd apply instead. Comments?  (it
> contains also some cleanup from old commented code)

Looks good.  Two comments:

 - what will happen if GOVERNOR is set to the empty string in
   /etc/default/cpufrequtils?  I suspect strange error messages will
   show up.  What about if GOVERNOR is set to a substring of an
   existing governor, like 'ondem'?

 - How will the long end_msg show up in usplash, where there is
   limited space for extra comments?

Besides these nitpick, your patch look a lot better than mine. :)

Happy hacking,
-- 
Petter Reinholdtsen


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to