Package: ldtp
Version: 0.8.0-1
Severity: serious
Justification: no longer builds from source

ldtp fails to build on Alpha:

[...]
if alpha-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/include/libxml2   
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -DORBIT2=1 -pthread 
-I/usr/include/at-spi-1.0 -I/usr/include/libbonobo-2.0 -I/usr/include/atk-1.0 
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/orbit-2.0 
-I/usr/include/bonobo-activation-2.0      -Wall -g -O2 -MT ldtp-logger.o -MD 
-MP -MF ".deps/ldtp-logger.Tpo" -c -o ldtp-logger.o ldtp-logger.c; \
        then mv -f ".deps/ldtp-logger.Tpo" ".deps/ldtp-logger.Po"; else rm -f 
".deps/ldtp-logger.Tpo"; exit 1; fi
ldtp-logger.c: In function 'ldtp_log':
ldtp-logger.c:59: error: invalid operands to binary !=
make[3]: *** [ldtp-logger.o] Error 1
make[3]: Leaving directory `/tmp/ldtp-0.8.0/src'
[...]

The problem is:

void 
ldtp_log (const char *template, ...)
{
        va_list ap;
[...]
        if (ldtp_debug != NULL && g_ascii_strcasecmp (ldtp_debug, "2") == 0 &&
            template != NULL && ap != NULL)

"ap != NULL" makes no sense at all, va_list is an opaque data type. It
just happens to compile on many architectures, because va_list happens
to be something that can be compared to 0. I suspect the check can
just be omitted.


-- System Information:
Debian Release: 4.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: alpha
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.20
Locale: LANG=C, [EMAIL PROTECTED] (charmap=ISO-8859-15)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to