On Mon, Jan 01, 2007 at 08:54:47PM +0100, Giuseppe Sacco wrote:
> [...]
> > this contradicts above comment/db_input meaning: if user answer 'no' then
> > server should _not_ restart, _regardless_ of previous state.
> 
> I think the message should be changed in anything similar to: "Hylafax
> is now correctly configured and may be run automatically. Should I
> unblock it in order to run in automatically or do you need any other
> custom setup before unblocking it?"

what about:

"Hylafax should have been configured properly now. If you answer 'YES' the 
server will be started now; note that RUN_HYLAFAX=1 will be set into 
/etc/default/hylafax so that it will start on boot as well. 
'NO' will leave /etc/default/hylafax as is and server won't be started now.
It might be started on next boot anyway, though, if RUN_HYLAFAX=1 was 
already set."

p=low here ie likely a newbie's behind keyboard; so a bit of explanations
won't hurt ;)

> I would use preinst for anything required during install. The faxmaster
> user isn't required for unpacking and setting up hylafax. Maybe the

ok

> 'stop' action could be moved in preinst stage.

sounds better to me.

...
> when anything special is required, i.e., for configuring modems before
> running hylafax.

... or tuning config on upgrade due to changes - eg 4.2.x -> 4.3.x.
 
> right. This is why the note have priority 'low'. If the install/upgrade

the point is that it'll start anyway if restart=true, regardless of priority
and user's answer. It's fine to go straight on and obey the 'restart' state,
if priority was >'low', but once user is asked, his response leads. 
If he said 'NO' then server shouldn't start, regardless of 'restart'.

> Do you still think it should be changed? I may do it, but I cannot block
> the installation process prompting the user with a 'high' priority

no need to block, nor change priority: if debconf is set for p=low, then 
user is asked and script must obey user's choice. Otherwise, all rest 
been equal, previous state set final state.

thanks
-- 
 paolo


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to