Hello! Sorry for the long delay, real life took recently quite all my free time.
On Wed, 30 Aug 2006 00:13:47 +0200, Faré wrote:
> On 29/08/06, Luca Capello <[EMAIL PROTECTED]> wrote:
>>> check_lisp_variable () {
>>> test -r /etc/cl-launchrc && . /etc/cl-launchrc
>>> test -r "$HOME/.cl-launchrc" && . "$HOME/.cl-launchrc"
>>> test -n ${SOFTWARE_SYSTEM} && LISP=${SOFTWARE_SYSTEM}
>>> }
> I have several issues with such a patch:
>
> (1) I took enough pain to get cl-launch running on a wide variety of
> shells (bash, zsh, posh, dash...) and I won't accept any bash-ism.
> Eval is OK.
I agree and I forgot to wrote that I tested my patch with dash (which
AFAIK is POSIX-compliant only), without any problem. Other common
tools I use for shell scripts are checkbash [1] and checkbashism [2].
> (2) since we're using eval I'd rather the variable be named
> LISP_stumpwm or something like that.
I thought about that, too, but I found that as ATM cl-launchrc should
only contains $LISP for a specific script, I preferred to use the
general $LISP.
> (3) this patch just won't work when we're in --dump mode, since it
> very wrongly overrides the $LISP from the dumped image. A script
> generated with --dump should NOT read any kind of cl-launchrc.
I never tested the --dump mode, so I cannot say anything. I'll
investigate to find a better solution.
> (4) If you hack cl-launch, you might want to run cl-launch -l "clisp
> sbcl cmucl gcl" -B tests from a temporary directory (complete with all
> installed and supported implementations). This will run the
> self-test.
Thank you for the hint!
Thx, bye,
Gismo / Luca
Footnotes:
[1] `apt-cache show debmake`
[2] `apt-cache show devscripts`
pgpydzT7lydRm.pgp
Description: PGP signature
