Kevin, Bruno, Please find attached a patch (against mondo-2.09-2) that should add full AFS support to mondo: - AFS will be excluded if '-N' is specified - AFS mounts will not be considered for scratch nor tmp anymore - exclude all directories specified via '-N' or '-E' when compiling file catalog (not AFS specific)
I've tested the attached patch and it looks ok to me. I have not found any regressions. Here are some more details/thoughts regarding the patch: - '-N' should be straight forward (like mvfs) - excluding AFS for scratch and tmp should be straight forward (like mvfs) - I'm using asprintf to compile string for find to exclude things, should be safe. - I'm using mr_strtok() to split up variable 'sth' using space as delimiter. Should be safe but comes with limitation that file names with spaces won't work. Whilst not a regression as we don't support this anyway at the moment, it might make things more difficult to change in the future. Given that (a) we don't know how far that future is still away and (b) there will be similar cases to be dealt with elsewhere in the code, I feel this is probably ok. - Variable 'sth' contains a number of entries that were explicitly mentioned in the find command string. Removed those to avoid duplicates. - I'm not 100% sure whether we wouldn't be better off patronising the user and categorically excluding AFS mounts like we do with MVFS. Maybe not a good idea, though - after all AFS contains normal files that we could theoretically back up using mondoarchive. Bruno/Kevin, it would be great if you could let me know your thoughts regarding the attached patch. Kevin, it would be great if you could apply the attached patch and test and provide feedback. Please let me know if you are not comfortable with patches and I'll make i386 packages available instead. Also, thanks for your hints regarding setting up AFS, Kevin. Following them on sid made things very easy for me, indeed. Cheers, Andree -- Andree Leidenfrost @ Debian Developer Sydney - Australia
mondo_bts#385790.diff
Description: Binary data
signature.asc
Description: This is a digitally signed message part
