On Sun, 9 Jul 2006, Harald Dunkel wrote:

If it is allowed, then I would suggest to copy the node in Curl_splayinsert to make sure that memory doesn't get out of scope in a calling function. See the attached patch.

Thanks for your work.

My testcase did not crash anymore, but of course the problem is not _that_ much reproducable.

Indeed, but you instead added a memory-leak. And I truly don't think this work-around is good enough to actually hide the problems for you properly...

Since the splay functions seem to be used internally only, this is surely just a workaround, if it helps at all.

A better work-around, if you want work-arounds, is to simply make Curl_expire() return immediately without doing anything at all. This too will make curl_multi_timeout() break, but there aren't that many actual users of that function (yet).

Neither of these work-arounds actually fix anything though, they just hide the problem.

--
         -=- Daniel Stenberg -=- http://daniel.haxx.se -=-
  ech`echo xiun|tr nu oc|sed 'sx\([s\x]\)\([\xoi]\)xo un\2\1 is xg'`ol



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to