On Mon, 10 Jul 2006, Harald Dunkel wrote:
Indeed, but you instead added a memory-leak. And I truly don't think this
work-around is good enough to actually hide the problems for you
properly...
How many entries would you usually expect for the splay tree? I doubt that
the memory leak is a serious problem, compared to the SEGV we have at the
moment.
The tree is not supposed to have many nodes (at most one node per easy handle
used within the multi handle), but it removes and re-adds nodes a fair number
of times and your "workaround" leaks a struct at every such new add.
A better work-around, if you want work-arounds, is to simply make
Curl_expire() return immediately without doing anything at all.
Creating a copy of node is more defensive. Of course it is just hiding the
problem.
My suggested "workaround" leaks nothing and have the same net effect as yours:
it breaks curl_multi_timeout().
Using curl I wouldn't be interested in its internal details, anyway.
Why would you? But hacking in "workarounds" is hardly what I call "using
curl".
--
-=- Daniel Stenberg -=- http://daniel.haxx.se -=-
ech`echo xiun|tr nu oc|sed 'sx\([s\x]\)\([\xoi]\)xo un\2\1 is xg'`ol
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
