Hello Martin, On Wed, Jun 28, 2006 at 09:00:51AM +0200, Martin Pitt wrote: > Package: acl > Version: 2.2.39-1 > Tags: patch > > The POT file created by the acl package is broken since it does not > have a proper header.
Well, that doesn't strictly make it "broken", but no matter. > We fixed this by removing the --omit-header > argument to xgettext and also updating the POT file on package build, > so that it is always current. Hmm. AFAICT, this isn't fixing the original problem. Reading https://launchpad.net/distros/ubuntu/+source/acl/+bug/40365 it seems there's valuable metadata that needs to be extracted from the .pot header, like charset, creation date, etc. When we auto-generate a header it means the "placeholder" fields (see below) are not being filled in, and creation date becomes simply "last build date", etc - heres the generated header... # SOME DESCRIPTIVE TITLE. # Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER # This file is distributed under the same license as the PACKAGE package. # FIRST AUTHOR <[EMAIL PROTECTED]>, YEAR. # #, fuzzy msgid "" msgstr "" "Project-Id-Version: PACKAGE VERSION\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2006-06-29 11:39+1000\n" "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n" "Last-Translator: FULL NAME <[EMAIL PROTECTED]>\n" "Language-Team: LANGUAGE <[EMAIL PROTECTED]>\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=CHARSET\n" "Content-Transfer-Encoding: 8bit\n" I guess a better way to approach this would be to have a separate file which contains just the header, with filled-in details, and then produce a .pot file during the build using the current macros, and finally install a .pot file with the two concatenated together. > $(MAKE) default > + cd po; rm -rf acl.pot; make acl.pot > touch built This is inconsistent with the rest of the build system - we should be descending down into "po" as a SUBDIR if this is to be regenerated every time, and using the default Makefile rule in that subdirectory. Your patch also doesn't consider the general case for building on platforms where xgettext is not installed, its assuming it is always there. Do you have time to attempt fixing some of these? If not, can you explain to me which of the .pot header fields are important for the Ubuntu translation folks, and which are not, and I'll attempt to find some time to address these issues for you. thanks. ps: I look after 5 source packages which use this same Makefile system (acl/attr/xfsprogs/xfsdump/dmapi), so we may as well take the time to fix it properly, once - here in acl - and I'll then ensure the changes get propogated to the rest of them too. -- Nathan -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
