Hello, On Mon 14 Jul 2025 at 10:54am +01, Ian Jackson wrote:
> Sean Whitton writes ("Bug#1108378: git-debpush: should warn for superfluous
> quilt mode option on command line"):
>> Your point is that if they do supply one, then we need to distinguish
>> between different possible failures to find one from the history,
>> between those that should still be fatal errors and those which should
>> be ignored because the --quilt option the user has passed is
>> pseudo-overriding them?
>
> Yes.
>
> But, some nuance:
>
> I'm not sure "pseudo-overriding" is the right framing. When the user
> passes --quilt we're only doing all this work *only* to detect user
> mistake (so that we can fail a check, or print a warning).
>
> Detecting user mistakes is a best effort activity for git-debpush.
>
> So being unable to determine whether this kind of mistake has been
> made is not an error in itself. But, while we're doing that, if we
> discover that everything is totally broken, we *should* bomb out.
Right.
--
Sean Whitton
signature.asc
Description: PGP signature
