Hello, On Tue 01 Jul 2025 at 02:46pm +01, Ian Jackson wrote:
> But implementing this may be nontrivial. quilt mode archaeology is > complex, and currently it is allowed to crash whenever it can't figure > things out. I think this proposal involves distinguishing "something > is unexpected about the git structure which means that we cannot > determine the quilt mode automatically" from "something is seriously > wrong and we should crash even if the user specified --quilt". Hmm, I think you must have misread my suggestion. I just mean that this code: > > # If the user didn't supply a quilt mode, look for it in a previous > # tag made by this script > if [ "x$quilt_mode" = x ] && [ "$format" = "3.0 (quilt)" ]; then > set +o pipefail # perl will SIGPIPE git-cat-file(1) here > if [ "x$last_debian_tag" != x ]; then > quilt_mode=$(git cat-file -p $(git rev-parse "$last_debian_tag") \ > | perl -wne'/^\[dgit.*--quilt=([a-z+]+).*\]$/ > or next; > print "$1\n"; exit') > fi > set -o pipefail > fi > should be run even if the user *did* supply a quilt mode, and if they are different it's a failed check. -- Sean Whitton
signature.asc
Description: PGP signature
