Package: release.debian.org
Severity: normal
User: release.debian....@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: normalize-au...@packages.debian.org, reic...@debian.org
Control: affects -1 + src:normalize-audio

Please unblock package normalize-audio

[ Reason ]
Versions -20 and -21 only add/improve the missing initialization of a single
variable.

[ Impact ]
If the initial (random) value is higher than the maximum of all samples in the
file, a wrong maximum is computed, and leads to wrong normalization afterwards.

[ Tests ]
Manual tests, see #1106841.

[ Risks ]
Trivial fix adding a missing variable initialization.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

unblock normalize-audio/0.7.7-21

Best regards,
  Joachim
diff -Nru normalize-audio-0.7.7/debian/changelog 
normalize-audio-0.7.7/debian/changelog
--- normalize-audio-0.7.7/debian/changelog      2024-12-29 18:17:01.000000000 
+0100
+++ normalize-audio-0.7.7/debian/changelog      2025-05-31 13:23:29.000000000 
+0200
@@ -1,3 +1,16 @@
+normalize-audio (0.7.7-21) unstable; urgency=medium
+
+  * Improve patch decode_struct.maxpow (initialize with zero instead of
+    -DBL_MAX).
+
+ -- Joachim Reichel <reic...@debian.org>  Sat, 31 May 2025 13:23:29 +0200
+
+normalize-audio (0.7.7-20) unstable; urgency=medium
+
+  * Add patch to initialize decode_struct.maxpow (Closes: #1106841).
+
+ -- Joachim Reichel <reic...@debian.org>  Fri, 30 May 2025 16:45:28 +0200
+
 normalize-audio (0.7.7-19) unstable; urgency=medium
 
   * Add patch to fix FTBFS with C23 (Closes: #1097474).
diff -Nru normalize-audio-0.7.7/debian/patches/fix-maxpow-initialization.patch 
normalize-audio-0.7.7/debian/patches/fix-maxpow-initialization.patch
--- normalize-audio-0.7.7/debian/patches/fix-maxpow-initialization.patch        
1970-01-01 01:00:00.000000000 +0100
+++ normalize-audio-0.7.7/debian/patches/fix-maxpow-initialization.patch        
2025-05-31 13:23:29.000000000 +0200
@@ -0,0 +1,12 @@
+Index: normalize-audio/src/mpegvolume.c
+===================================================================
+--- normalize-audio.orig/src/mpegvolume.c
++++ normalize-audio/src/mpegvolume.c
+@@ -175,6 +175,7 @@ signal_max_power_mp3(char *filename, str
+   ds.eof = 0;
+   ds.windowsz = 0;
+   ds.samples_so_far = 0;
++  ds.maxpow = 0.0;
+   /* initialize peaks to effectively -inf and +inf */
+   si->max_sample = samplemin;
+   si->min_sample = samplemax;
diff -Nru normalize-audio-0.7.7/debian/patches/series 
normalize-audio-0.7.7/debian/patches/series
--- normalize-audio-0.7.7/debian/patches/series 2024-12-29 18:17:01.000000000 
+0100
+++ normalize-audio-0.7.7/debian/patches/series 2025-05-30 16:45:03.000000000 
+0200
@@ -10,3 +10,4 @@
 fix-parallel-test-suite.patch
 improve-normalize-ogg-showstats-962236.patch
 fix-c23.patch
+fix-maxpow-initialization.patch

Reply via email to