On 2025-05-15 10:51:13 +0200, Paul Gevers wrote:
> Hi,
>
> On 14-05-2025 16:44, Alexandre Detiste wrote:
> > This is a pre-approval request.
>
>
> Just wondering (and not a blocker), why did you file this as a pre-approval?
> The package is on the autoremoval list and delaying the upload reduces the
> time for testing the fix by others.
>
> > [ Reason ]
> > xmlrpc-c/1.59.03-10 fix the FTBFS of the reverse dependencies
> > whom for some other reasons end-up dependening on 'pkgconf'
>
>
> I understand from the reply from Guillem that this doesn't affect the Debian
> archive.
>
> > I revuild the reverse dependencies again just fine.
> >
> > Reverse-Build-Depends
> > =====================
> > * flowgrind (for libxmlrpc-core-c3-dev)
> > * rtorrent (for libxmlrpc-core-c3-dev)
> > * rtpengine (for libxmlrpc-core-c3-dev)
> > * tlf (for libxmlrpc-core-c3-dev)
>
>
> Thanks for testing that. Did you do any checking that the build was also
> correct? If so, what did you check?
>
> > the remaining debdiff is small
>
>
> I understand that the real expat fix is the following:
>
> > diff --git a/debian/control b/debian/control
> > index c7d9041..ef000c7 100644
> > --- a/debian/control
> > +++ b/debian/control
> > @@ -60,6 +60,7 @@ Architecture: any
> > Depends:
> > libc6-dev,
> > libcurl4-openssl-dev | libcurl4-gnutls-dev,
> > + libexpat1-dev,
> > libxmlrpc-core-c3t64 (= ${binary:Version}),
> > libxmlrpc-util-dev,
> > ${misc:Depends},
> > --- a/debian/patches/xmlrpc-c-1.59.03-use-system-expat.patch
> > +++ b/debian/patches/xmlrpc-c-1.59.03-use-system-expat.patch
> > @@ -120,6 +120,16 @@ Subject: [PATCH] Use system libexpat rather than
> > bundled lib/expat/ for
> > endif
> > $(LIBXMLRPC_MODS:%=%.o) \
> > +@@ -339,7 +337,8 @@
> > + @echo 'Description: Xmlrpc-c basic XML-RPC library'
> > >>$@
> > + @echo 'Version: $(XMLRPC_VERSION_STRING)'
> > >>$@
> > + @echo
> > >>$@
> > +- @echo 'Requires: xmlrpc_util $(XML_PKGCONFIG_REQ)'
> > >>$@
> > ++ @echo 'Requires: xmlrpc_util'
> > >>$@
> > ++ @echo 'Requires.private: $(XML_PKGCONFIG_REQ)'
> > >>$@
> > + @echo 'Libs: -L$${libdir} -lxmlrpc'
> > >>$@
> > + @echo 'Cflags: -I$${includedir}'
> > >>$@
> > +
>
> I must admit I don't oversee all the consequences here, so I hope that one
> of the other RT members can double check, but I think you should upload to
> unstable already.
I would be more comfortable with the dependency change only. Changing
pkgconfig files at this stage of the freeze is IMHO too late. The
potential overlinking is handled by -Wl,--as-needed anyway.
Cheers
--
Sebastian Ramacher
