[John Paul Adrian Glaubitz] > here is my initial review. Thank you for the valuable input. Do you want me to send a new patch?
> So, it should probably be: > > linux-minidisc.minidisc-utils.metainfo.xml Right. Note, '-' is not allwed in the IDs, so I recommend replacing these with '_', ie linux_minidisc.minidisc_utils.metainfo.xml. And the ID and file name should be in reverse DNS format, and as linux_minidisc is not a topleven DNS domain name, I suggest to pick another one. I picked one based on the home page URL. It does not matter much which reverse DNS domain you pick as long as it is unique. :) > I'll take care of forwarding the patch once it has been integrated > into the Debian package. Very good. :) > The set of USB ids for NetMD-compatible and HiMD-compatible devices is > certainly not identical as not every NetMD-compatible MiniDisc Walkman > is also compatible with HiMD as the latter is a newer standard. HiMD > devices are compatible with NetMD, however. I am very glad you had a look. I suspect I based the list on the udev rule in the source, but do not know any details of supported devices. -- Happy hacking Petter Reinholdtsen
