Hi Petter, here is my initial review.
On Thu, 2024-07-25 at 07:14 +0200, Petter Reinholdtsen wrote: > Note, this also applies to the minidisk-utils package. Please note that the package is called "minidisc-utils", not "minidisk-utils". The rule of thumb is: If it's optical, it's spelled "disc", if it's magnetic, it's spelled "disk". > This is a useful way to check the appstream metainfo: > > appstreamcli validate-tree --explain debian/qhimdtransfer > appstreamcli validate-tree --explain debian/minidisk-utils Same typo. > diff --git a/debian/minidisc-utils.install b/debian/minidisc-utils.install > index 6993a21..37a8176 100644 > --- a/debian/minidisc-utils.install > +++ b/debian/minidisc-utils.install > @@ -1,3 +1,4 @@ > himdcli/himdcli /usr/bin > netmdcli/netmdcli /usr/bin > netmd/etc/netmd.rules /lib/udev/rules.d/ > +de.fu_berlin.physik.linux_minidisk.utils.metainfo.xml usr/share/metainfo The upstream project is "linux-minidisc" and is not associated with my email address at the Physics department. So, it should probably be: linux-minidisc.minidisc-utils.metainfo.xml > diff --git a/debian/patches/1000-appstream-metainfo.patch > b/debian/patches/1000-appstream-metainfo.patch > new file mode 100644 > index 0000000..3d65fa9 > --- /dev/null > +++ b/debian/patches/1000-appstream-metainfo.patch > @@ -0,0 +1,121 @@ > +Description: Added AppStream metainfo XML with hardware provide info. > + This allow isenkram to propose this package when the hardware is This allow_s_. > + present. > +Author: Petter Reinholdtsen > +Forwarded: no I'll take care of forwarding the patch once it has been integrated into the Debian package. > +Last-Update: 2024-07-25 > +--- > +Index: > linux-minidisc-debian-upstream/de.fu_berlin.physik.linux_minidisk.utils.metainfo.xml > +=================================================================== > +--- /dev/null 1970-01-01 00:00:00.000000000 +0000 > ++++ > linux-minidisc-debian-upstream/de.fu_berlin.physik.linux_minidisk.utils.metainfo.xml > 2024-07-25 05:05:15.955057068 +0000 > +@@ -0,0 +1,52 @@ > ++<?xml version="1.0" encoding="UTF-8"?> > ++<component type="desktop"> > ++ <id>de.fu_berlin.physik.linux_minidisk.utils</id> > ++ <metadata_license>MIT</metadata_license> > ++ <name>minidisc-utils</name> > ++ <summary>Command line utilities for MiniDisc access</summary> > ++ <description> > ++ <p>This package contains several utilities which allow one to > ++ access NetMD and HiMD devices through a command line > ++ interface. The utilities allow one to transfer tracks to and from > ++ NetMD and HiMD devices as well as erase tracks, display tracks and > ++ renaming tracks among other functions supported by libnetmd and > ++ libhimd libraries.</p> > ++ </description> > ++ <url type="homepage">https://wiki.physik.fu-berlin.de/linux-minidisc</url> > ++ <provides> > ++ <modalias>usb:v054Cp017Ed*</modalias> > ++ <modalias>usb:v054Cp0180d*</modalias> > ++ <modalias>usb:v054Cp0182d*</modalias> > ++ <modalias>usb:v054Cp0184d*</modalias> > ++ <modalias>usb:v054Cp0186d*</modalias> > ++ <modalias>usb:v054Cp01E9d*</modalias> > ++ <modalias>usb:v054Cp0219d*</modalias> > ++ <modalias>usb:v054Cp021Bd*</modalias> > ++ <modalias>usb:v054Cp022Cd*</modalias> > ++ <modalias>usb:v054Cp023Cd*</modalias> > ++ <modalias>usb:v054Cp0286d*</modalias> > ++ <modalias>usb:v054Cp0113d*</modalias> > ++ <modalias>usb:v054Cp014Cd*</modalias> > ++ <modalias>usb:v04DDp7202d*</modalias> > ++ <modalias>usb:v04DDp9013d*</modalias> > ++ <modalias>usb:v04DDp9014d*</modalias> > ++ <modalias>usb:v054Cp0036d*</modalias> > ++ <modalias>usb:v054Cp0075d*</modalias> > ++ <modalias>usb:v054Cp007Cd*</modalias> > ++ <modalias>usb:v054Cp0080d*</modalias> > ++ <modalias>usb:v054Cp0081d*</modalias> > ++ <modalias>usb:v054Cp0084d*</modalias> > ++ <modalias>usb:v054Cp0085d*</modalias> > ++ <modalias>usb:v054Cp0086d*</modalias> > ++ <modalias>usb:v054Cp00C6d*</modalias> > ++ <modalias>usb:v054Cp00C7d*</modalias> > ++ <modalias>usb:v054Cp00C8d*</modalias> > ++ <modalias>usb:v054Cp00C9d*</modalias> > ++ <modalias>usb:v054Cp00CAd*</modalias> > ++ <modalias>usb:v054Cp00EBd*</modalias> > ++ <modalias>usb:v054Cp0101d*</modalias> > ++ <modalias>usb:v054Cp0188d*</modalias> > ++ <modalias>usb:v054Cp018Ad*</modalias> > ++ <modalias>usb:v054Cp021Dd*</modalias> > ++ </provides> > ++</component> > +Index: > linux-minidisc-debian-upstream/de.fu_berlin.physik.linux_minidisk.qhimdtransfer.metainfo.xml > +=================================================================== > +--- /dev/null 1970-01-01 00:00:00.000000000 +0000 > ++++ > linux-minidisc-debian-upstream/de.fu_berlin.physik.linux_minidisk.qhimdtransfer.metainfo.xml > 2024-07-25 05:05:27.991182234 +0000 > +@@ -0,0 +1,52 @@ > ++<?xml version="1.0" encoding="UTF-8"?> > ++<component type="desktop"> > ++ <id>de.fu_berlin.physik.linux_minidisk.qhimdtransfer</id> > ++ <metadata_license>MIT</metadata_license> > ++ <name>qhimdtransfer</name> > ++ <summary>Transfer software for HiMD Walkman</summary> > ++ <description> > ++ <p>qhimdtransfer is a simple graphical user interface application > ++ for accessing MiniDisc devices. Currently, qhimdtransfer supports > ++ HiMD devices only through libhimd. Support for NetMD devices > ++ through libnetmd is being planned and implemented by upstream for > ++ the next releases.</p> > ++ </description> > ++ <url type="homepage">https://wiki.physik.fu-berlin.de/linux-minidisc</url> > ++ <launchable type="desktop-id">qhimdtransfer.desktop</launchable> > ++ <provides> > ++ <modalias>usb:v054Cp017Ed*</modalias> > ++ <modalias>usb:v054Cp0180d*</modalias> > ++ <modalias>usb:v054Cp0182d*</modalias> > ++ <modalias>usb:v054Cp0184d*</modalias> > ++ <modalias>usb:v054Cp0186d*</modalias> > ++ <modalias>usb:v054Cp01E9d*</modalias> > ++ <modalias>usb:v054Cp0219d*</modalias> > ++ <modalias>usb:v054Cp021Bd*</modalias> > ++ <modalias>usb:v054Cp022Cd*</modalias> > ++ <modalias>usb:v054Cp023Cd*</modalias> > ++ <modalias>usb:v054Cp0286d*</modalias> > ++ <modalias>usb:v054Cp0113d*</modalias> > ++ <modalias>usb:v054Cp014Cd*</modalias> > ++ <modalias>usb:v04DDp7202d*</modalias> > ++ <modalias>usb:v04DDp9013d*</modalias> > ++ <modalias>usb:v04DDp9014d*</modalias> > ++ <modalias>usb:v054Cp0036d*</modalias> > ++ <modalias>usb:v054Cp0075d*</modalias> > ++ <modalias>usb:v054Cp007Cd*</modalias> > ++ <modalias>usb:v054Cp0080d*</modalias> > ++ <modalias>usb:v054Cp0081d*</modalias> > ++ <modalias>usb:v054Cp0084d*</modalias> > ++ <modalias>usb:v054Cp0085d*</modalias> > ++ <modalias>usb:v054Cp0086d*</modalias> > ++ <modalias>usb:v054Cp00C6d*</modalias> > ++ <modalias>usb:v054Cp00C7d*</modalias> > ++ <modalias>usb:v054Cp00C8d*</modalias> > ++ <modalias>usb:v054Cp00C9d*</modalias> > ++ <modalias>usb:v054Cp00CAd*</modalias> > ++ <modalias>usb:v054Cp00EBd*</modalias> > ++ <modalias>usb:v054Cp0101d*</modalias> > ++ <modalias>usb:v054Cp0188d*</modalias> > ++ <modalias>usb:v054Cp018Ad*</modalias> > ++ <modalias>usb:v054Cp021Dd*</modalias> > ++ </provides> > ++</component> The set of USB ids for NetMD-compatible and HiMD-compatible devices is certainly not identical as not every NetMD-compatible MiniDisc Walkman is also compatible with HiMD as the latter is a newer standard. HiMD devices are compatible with NetMD, however. > diff --git a/debian/patches/series b/debian/patches/series > index 923d43d..cdada98 100644 > --- a/debian/patches/series > +++ b/debian/patches/series > @@ -1 +1,2 @@ > 0001-use-builddate-from-changelog.patch > +1000-appstream-metainfo.patch > diff --git a/debian/qhimdtransfer.install b/debian/qhimdtransfer.install > index 699f7a9..a07571b 100644 > --- a/debian/qhimdtransfer.install > +++ b/debian/qhimdtransfer.install > @@ -10,3 +10,4 @@ qhimdtransfer/icons/qhimdtransfer_256.png /usr/share/pixmaps > qhimdtransfer/icons/qhimdtransfer_512.png /usr/share/pixmaps > qhimdtransfer/qhimdtransfer /usr/bin > qhimdtransfer/qhimdtransfer*qm /usr/share/qhimdtransfer/translations/ > +de.fu_berlin.physik.linux_minidisk.qhimdtransfer.metainfo.xml > usr/share/metainfo Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
