Hey Lorenzo, On Tue, Jan 28, 2025 at 10:20:58PM +0100, Lorenzo wrote: > As for n.4, I'm not convinced is needed:
I agree, based on your explanation! > first of all, did you look at the source with quilt patches applied? Yes and no, initially I missed this point as I was experimenting with the main issue and saw this in the process, but you'd already fixed the main one! I kept my remaining (bad) 'fixes' without giving them enough attention. Sorry - please do drop patch 4! I think ideally we'd capture the logs from the feature tests to have a chance of spotting false results that might turn up over time but I reckoned I'd already done enough surgery on the build scripts for the time being! > This is code selected for 2.1.2-60 > (you can get build logs with "getbuildlog runit 2.1.2-60 amd64" > > /* sysdep: +dirent */ > /* sysdep: +waitpid */ > /* sysdep: +sigaction */ > /* sysdep: +sigprocmask */ > /* sysdep: +sysselect */ > /* sysdep: +ulong64 */ > /* sysdep: +poll */ > /* sysdep: +mkfifo */ > /* sysdep: +flock */ > /* sysdep: -shortsetgroups */ > /* sysdep: +std reboot */ > /* sysdep: -utmpx */ Looks plausible to me! Andrew
