Control: found -1 runit/2.1.2-60 Control: tags -1 moreinfo Hi Andrew,
thanks for this. Overall, I like to drop quilt patches and that intermittent blhc failure was annoying. So while I still didn't had the time to test them yet, I'm likely going to accept patches 1,2,3. On Fri, 10 Jan 2025 00:18:28 +0000 Andrew Bower <and...@bower.uk> wrote: > > 4) Some of the feature test programs (tst*.c) had build errors with > > recent compilers that were hidden and therefore resulted in the > > wrong build choices being made silently. Some of these cases were > > handled in #1075484. As for n.4, I'm not convinced is needed: first of all, did you look at the source with quilt patches applied? do $ quilt push -a inside runit source I had looked at this in august 2024, if I recall correctly: tryulong64.c I think it's already fixed with #include <unistd.h> trypoll.c same as for tryulong64.c tryshsgr.c I think the test trying to detect if the platform has short gid, and the answer is likely "no" (it should fail); in any case it's no longer used in the source code and was removed by upstream in 2.2.0 trymkffo.c I'm not able to tell exactly what the test is for; when the test fails mknod is used instead of mkfifo (see fifo.c). I'm not sure the return code from mkfifo is relevant.. Anyway, for all Debian archs mkfifo is fine and is selected, so while I would be curious to know how this test works, I don't think we are using wrong code because of this. And I prefer to not carry a quilt patch unless it's needed. This is code selected for 2.1.2-60 (you can get build logs with "getbuildlog runit 2.1.2-60 amd64" /* sysdep: +dirent */ /* sysdep: +waitpid */ /* sysdep: +sigaction */ /* sysdep: +sigprocmask */ /* sysdep: +sysselect */ /* sysdep: +ulong64 */ /* sysdep: +poll */ /* sysdep: +mkfifo */ /* sysdep: +flock */ /* sysdep: -shortsetgroups */ /* sysdep: +std reboot */ /* sysdep: -utmpx */ wrong section of code happened in 2.1.2-59 due to a change in dpkg, but other than that I think we are fine. Lorenzo
