Control: tags -1 +moreinfo

Xiyue,

Preamble...

Thank you for taking the time to prepare this package and your contribution to
the Debian project.

This review is offered to help package submitters to Debian mentors inorder to
improve their packages prior to possible sponsorship into Debian. There is no
obligation on behalf of the submitter to make any alterations based upon
information provided in the review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Good

2. Lintian [3]: Good

3. Licenses [4]: Issue

philwyett@ks-tarkin:~/Development/builder/debian/geiser-0.31.1$ lrc
en: Versions: recon 3.3  check 3.3.9-1

Parsing Source Tree  ....
Reading d/copyright  ....
Running licensecheck ....

d/copyright      | licensecheck

GFDL-1.3         | GFDL-1.3+         doc/geiser.texi

* The 'doc' directory contains files with a variety of licenses e.g.
'doc/makefile'.

4. Watch file [uscan --force-download]: Good

5. Build Twice (build source after successful build [1]: Issue

dpkg-deb: building package 'elpa-geiser' in '../elpa-geiser_0.31.1-1_all.deb'.
 dpkg-genbuildinfo -O../geiser_0.31.1-1_amd64.buildinfo
 dpkg-genchanges -O../geiser_0.31.1-1_amd64.changes
dpkg-genchanges: info: including full source code in upload
 dpkg-source --after-build .
dpkg-buildpackage: info: full upload (original source is included)
dpkg-genchanges: info: including full source code in upload
dpkg-buildpackage: info: source package geiser
dpkg-buildpackage: info: source version 0.31.1-1
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by Xiyue Deng <manp...@gmail.com>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source --before-build .
 debian/rules clean
dh clean --with elpa
   dh_clean
 dpkg-source -b .
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building geiser using existing ./geiser_0.31.1.orig.tar.xz
dpkg-source: error: cannot represent change to doc/html/img/autodoc-multi.png:
binary file contents changed
dpkg-source: error: add doc/html/img/autodoc-multi.png in
debian/source/include-binaries if you want to store the modified binary in the
debian tarball
dpkg-source: error: cannot represent change to doc/html/img/autodoc-req.png:
binary file contents changed
dpkg-source: error: add doc/html/img/autodoc-req.png in debian/source/include-
binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to doc/html/img/autodoc-scm.png:
binary file contents changed
dpkg-source: error: add doc/html/img/autodoc-scm.png in debian/source/include-
binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to doc/html/img/autodoc-var.png:
binary file contents changed
dpkg-source: error: add doc/html/img/autodoc-var.png in debian/source/include-
binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to doc/html/img/docstring-
racket.png: binary file contents changed
dpkg-source: error: add doc/html/img/docstring-racket.png in
debian/source/include-binaries if you want to store the modified binary in the
debian tarball
dpkg-source: error: cannot represent change to doc/html/img/docstring.png:
binary file contents changed
dpkg-source: error: add doc/html/img/docstring.png in debian/source/include-
binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to doc/html/img/eval-error.png:
binary file contents changed
dpkg-source: error: add doc/html/img/eval-error.png in debian/source/include-
binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to doc/html/img/geiser-mode.png:
binary file contents changed
dpkg-source: error: add doc/html/img/geiser-mode.png in debian/source/include-
binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to doc/html/img/guile-eval-
error.png: binary file contents changed
dpkg-source: error: add doc/html/img/guile-eval-error.png in
debian/source/include-binaries if you want to store the modified binary in the
debian tarball
dpkg-source: error: cannot represent change to doc/html/img/mod-completion.png:
binary file contents changed
dpkg-source: error: add doc/html/img/mod-completion.png in
debian/source/include-binaries if you want to store the modified binary in the
debian tarball
dpkg-source: error: cannot represent change to doc/html/img/repl-autodoc.png:
binary file contents changed
dpkg-source: error: add doc/html/img/repl-autodoc.png in debian/source/include-
binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to doc/html/img/repl-images.png:
binary file contents changed
dpkg-source: error: add doc/html/img/repl-images.png in debian/source/include-
binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to doc/html/img/repl-menu.png:
binary file contents changed
dpkg-source: error: add doc/html/img/repl-menu.png in debian/source/include-
binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to doc/html/img/repl-mod.png:
binary file contents changed
dpkg-source: error: add doc/html/img/repl-mod.png in debian/source/include-
binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to doc/html/img/repls.png: binary
file contents changed
dpkg-source: error: add doc/html/img/repls.png in debian/source/include-
binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: unrepresentable changes to source
dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 1
I: copying local configuration
E: Failed autobuilding of package
I: unmounting dev/ptmx filesystem
I: unmounting dev/pts filesystem
I: unmounting dev/shm filesystem
I: unmounting proc filesystem
I: unmounting sys filesystem
I: cleaning the build env 
I: removing directory /var/cache/pbuilder/build/1575539 and its subdirectories
philwyett@ks-tarkin:~/Development/builder/debian$

6. Reproducible builds [5]: Good

7. Install [No previous installs]: Not performed at this time

8. Upgrade [Over previous installs if any]: Not performed at this time

Additional...

A. A variety of bugs are covered in this update and is a large version leap.
What test plan is in place to minimise any issues/regressions?

B. Bug 897140 should have its ownership taken to declare it is being worked on
and show a point of contact for communication.

Summary...

I believe 'geiser' is not yet ready for sponsorship at this time. Could the
contributor rectify one of more of the raised issues.

Once updated to your satisfaction and a new upload done, please remove the
'moreinfo' tag on the Request For Sponsorship (RFS) bug report.

To remove 'moreinfo' tag, add below line to top of email replying to bug report
when a new upload is made.

Control: tags -1 -moreinfo

Please try the below on your packages...

[1] pbuilder:

  * Command for 1.: sudo pbuilder build <PACKAGE>.dsc
  * Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild -d unstable <PACKAGE>.dsc
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian --display-info --verbose --fail-on error --info --pedantic
--show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different
results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

  Note: Please report false positives as bug reports against 'licenserecon'.

[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
  
Regards

Phil

-- 

Donations...

Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

--

"I play the game for the game’s own sake"

Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

--

Internet Relay Chat (IRC): kathenas

Website: https://kathenas.org

Instagram: https://instagram.com/kathenasorg

Threads: https://www.threads.net/@kathenasorg

--

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to