Bug#1089413: physlock: Supporting rootless builds by default

[Niels Thykier]

Control: tags -1 patch

On Sat, 7 Dec 2024 21:04:02 +0100 Niels Thykier <ni...@thykier.net> wrote:

Source: physlock
Version: 13-1
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
physlock failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]

Hi

Please see attached as a patch.



Best regards,
Niels


diff -Nru physlock-13/debian/changelog physlock-13/debian/changelog
--- physlock-13/debian/changelog        2019-01-28 21:42:45.000000000 +0100
+++ physlock-13/debian/changelog        2024-12-31 13:47:04.000000000 +0100
@@ -1,3 +1,15 @@
+physlock (13-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Make requirement for root when building the package explicit.
+    (Closes: #1089413)
+  * Reorder some code in debian/rules to make it easier to support
+    rootless builds correctly in a later version. With this change,
+    only upstream makefile will need a patch followed by setting
+    `Rules-Requires-Root` to `no`.
+
+ -- Niels Thykier <ni...@thykier.net>  Tue, 31 Dec 2024 12:47:04 +0000
+
 physlock (13-1) unstable; urgency=medium
 
   * [5ed3be0] New upstream version 12 (was not uploaded to Debian yet
diff -Nru physlock-13/debian/control physlock-13/debian/control
--- physlock-13/debian/control  2019-01-28 21:42:18.000000000 +0100
+++ physlock-13/debian/control  2024-12-31 13:45:12.000000000 +0100
@@ -6,6 +6,7 @@
  debhelper (>= 10),
  libpam0g-dev,
  libsystemd-dev,
+Rules-Requires-Root: binary-targets
 Standards-Version: 4.3.0
 Homepage: https://github.com/muennich/physlock
 Vcs-git: https://salsa.debian.org/mika/physlock.git
diff -Nru physlock-13/debian/rules physlock-13/debian/rules
--- physlock-13/debian/rules    2017-08-17 14:04:45.000000000 +0200
+++ physlock-13/debian/rules    2024-12-31 13:45:47.000000000 +0100
@@ -12,8 +12,8 @@
 # set appropriate PREFIX
 override_dh_auto_install:
        make PREFIX=$(shell pwd)/debian/physlock/usr install
+
+
+execute_after_dh_fixperms:
        # ensure setuid bit is enabled
        chmod u+s $(shell pwd)/debian/physlock/usr/bin/physlock
-
-override_dh_fixperms:
-       dh_fixperms --exclude /usr/bin/physlock

I intend to NMU to make progress on the MBF if I do not hear from you on this. It would help me if you either uploaded this soon or approved the NMU (enabling me to skip the delay). Thanks in advance.

OpenPGP_signature.asc
Description: OpenPGP digital signature