tags 1086649 patch
thanks
I cannot guarantee that anyone can compile it with any cpu they own,
if not disabling hardware-related dh_auto_test completely.
Well, if the tests are going to be ignored when they fail in bookworm,
then (imho) it does not make sense to have the build fail when the tests
fail (in bookworm). The package has proven to be reproducible:
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/cpuinfo.html
so it would build the same without the tests.
At the very minimum, I would apply the attached patch. I think it would
be a lot better than having a package in stable which progressively
starts to fail more and more as people try to build it on
progressively new hardware.
Another option would be to run the tests followed by "|| true", so that
the output still reflects in the build log.
I understand and agree that backporting the good code from unstable,
where you point out that the code does not fail when the CPU is not
recognized, might take some time and effort (and a little bit of bureaucracy,
I would be willing to help on that front if necessary), but disabling
the tests (only in bookworm) seems simple and effective, and solves
the Policy violation.
Thanks.
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+cpuinfo (0.0~git20240830.fa1c679-5+deb12u1) bookworm; urgency=medium
+
+ * Team upload.
+ * Disable the tests in stable so that the package builds properly
+ on a system with an unrecognized CPU. Closes: #1086649.
+
+ -- Shengqi Chen <harry-c...@outlook.com> Sun, 03 Nov 2024 19:08:00 +0100
+
cpuinfo (0.0~git20240830.fa1c679-5) unstable; urgency=medium
* Team upload.
--- a/debian/rules
+++ b/debian/rules
@@ -13,11 +13,6 @@ override_dh_auto_configure:
-DCMAKE_SKIP_RPATH=ON
override_dh_auto_test:
-ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
- if [ -r /proc/cpuinfo ]; then cat /proc/cpuinfo ; else false; fi
- if [ -x ./$(shell ls -d obj-*)/cpuid-dump ]; then ./$(shell ls -d
obj-*)/cpuid-dump; fi
- -LD_LIBRARY_PATH=$(shell pwd)/$(shell ls -d obj-*) dh_auto_test
-endif
override_dh_missing:
dh_missing --list-missing
