On 13.07.24 17:48, Jonas Smedegaard wrote:
Quoting Matthias Geiger (2024-07-13 17:25:06)
On 09.07.24 08:14, Blair Noctis wrote:
The errors came from the fact that os_pipe is sync, while isahc is async. I've
implemented a simple wrapper for the pipe reader & writer; rather long, thus put
in a fork: https://salsa.debian.org/ncts/rust-isahc/-/commits/replace-sluice.
Note that os_pipe can fail, thus two `todo!()`s. OTOH, sluice returns directly
the pipe, without wrapping in Result, so I think there is space for improvement.
Blair,
thanks for this. Jonas, with this patch at hand, are you ok if I file a
RM request for sluice then ?
isahc is RC-buggy anyway and would need an additional aptch for polling 2.x.
I updated all relevant crates for the Rust team (including zbus and all
rdeps). Once sluice is removed I'd suggest we flip the switch then.
Fine with me to then flip the switch *now*, as we can fix isahc/sluic in
parallel the the pile of involved packages entering unstable.
Are you ok with flipping the switch *now*?
I need to build netavark with zbus 4.0 and ask siretart if it's ok; then
we can do this. I will look into netavark today; maybe we can upload
everything Sunday morning then ?
best,
werdahias
