Control: tags -1 + moreinfo Hi Manuel,
Preamble...
Thanks for taking time to create this package and your contribution to Debian.
The below review is for assistance. It is offered to help submitters of
packages to Debian mentors improve their packages prior to possible
sponsorship into Debian. There is no obligation on behalf of the subitter to
make any alterations based upon information provided in the review.
Review...
1. Build: Fail
dpkg-buildpackage
-----------------
Command: dpkg-buildpackage --sanitize-env -us -uc -mPhil Wyett
<philip.wy...@kathenas.org> -ePhil
Wyett <philip.wy...@kathenas.org> -rfakeroot
dpkg-buildpackage: info: source package baby
dpkg-buildpackage: info: source version 1.0.29-1
dpkg-buildpackage: info: source distribution unstable
dpkg-source --before-build .
dpkg-buildpackage: info: host architecture amd64
fakeroot debian/rules clean
dh clean
debian/rules override_dh_auto_clean
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_auto_clean
rm -f baby
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_clean
dpkg-source -b .
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: verifying ./baby_1.0.29.orig.tar.gz.asc
dpkg-source: info: building baby using existing ./baby_1.0.29.orig.tar.gz
dpkg-source: info: building baby using existing ./baby_1.0.29.orig.tar.gz.asc
dpkg-source: info: building baby in baby_1.0.29-1.debian.tar.xz
dpkg-source: info: building baby in baby_1.0.29-1.dsc
debian/rules build
dh build
dh_update_autotools_config
dh_autoreconf
debian/rules override_dh_auto_build
make[1]: Entering directory '/<<PKGBUILDDIR>>'
go mod init baby
go: creating new go.mod: module baby
go: to add module requirements and sums:
go mod tidy
go build -o baby
failed to initialize build cache at /sbuild-nonexistent/.cache/go-build: mkdir
/sbuild-nonexistent:
permission denied
make[1]: *** [debian/rules:8: override_dh_auto_build] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:4: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
--------------------------------------------------------------------------------
Build finished at 2024-07-04T05:51:06Z
Finished
--------
2. Lintian: Not performed due to (1. Build).
3. Licenses: Issue
It is best practice to have a separate section for Debian files. The majority
of Debian Developers
will not sponsor a package without it.
Example:
Files: debian/*
Copyright: Copyright (C) 2024 Manuel Guerra <ar.manuelgue...@gmail.com>
License: GPL-3+
4. Build Twice (sudo pbuilder build --twice <package>.dsc): Not performed due
to (1. Build).
5. Reproducible builds (reporotest)[1]: Not performed due to (1. Build).
6. Install (No previous installs): Not performed due to (1. Build).
7. Upgrade (Over previous installs if any): Not performed due to (1. Build).
Additional...
A. Need for a language specific 'debian/ppostinst'?
B. 'debian/patches' folder is not needed if no patches in use.
C. 'debian/misc:Built-Using' and empty?
D. 'debian/baby.lintian-overrides', I would remove for now. Seeing lintian
warnings while developing
a new package for Debian is not a bad thing.
E. 'debian/watch' - Broken.
philwyett@ks-windu:~/Development/builder/debian/mentoring/baby-1.0.29$ uscan
--force-download
uscan warn: In directory ., downloading
https://github.com/manuwarfare/baby/archive/refs/tags/v1.0.tar.gz.asc failed:
404 Not Found
uscan die: FAIL Checking OpenPGP signature (no signature file downloaded).
F. 'debian/source/include-binaries' and empty?
G. 'baby.conf' empty?
H. 'debian/missing-sources/main.go'?
One thing at a time Manuel. If you need to, please ask, we are here to help.
I believe baby is not yet ready for sponsorship/upload. Could the contributor
rectify one of more of
the rasied issues. Once updated to your satisfaction and a new upload done,
please remove the
'moreinfo' on the Request For Sponsorship (RFS) bug report.
[1] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
Regards
Phil
--
Internet Relay Chat (IRC): kathenas
Website: https://kathenas.org
Instagram: https://instagram.com/kathenasorg/
Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
signature.asc
Description: This is a digitally signed message part
