Hi, Update regarding dh_auto_test:
* Able to fix issue when testing docker cli * Added a patch to skip TestBuildWithBuilder test for docker cli, as it was failing when building on sbuild environment (no issues observed when built using dpkg-buildpackage). Link: https://salsa.debian.org/badrikesh/docker/-/blob/badrikesh/docker24/debian/patches/test--skip-TestBuildWithBuilder.patch?ref_type=heads Error: ``` | === Failed | === FAIL: cmd/docker TestBuildWithBuilder/custom_context (0.00s) | builder_test.go:82: assertion failed: error is not nil: mkdir /sbuild-nonexistent: permission denied | | === FAIL: cmd/docker TestBuildWithBuilder (0.01s) ``` Another issue is when using Debian version of golang-github-gotestyourself-gotest.tools-dev, observing issue as: ``` | # github.com/docker/cli/cli/connhelper/commandconn [github.com/docker/cli/cli/connhelper/commandconn.test] | cli/connhelper/commandconn/commandconn_unix_test.go:184:21: undefined: is.ErrorIs | cli/connhelper/commandconn/commandconn_unix_test.go:214:21: undefined: is.ErrorIs | ✓ cli/compose/schema (60ms) | ✓ cli/config (11ms) | ✓ cli/config/configfile (6ms) | ∅ cli/config/types | ✓ cli/config/credentials (5ms) | ✖ cli/connhelper/commandconn | ∅ cli/context | ∅ cli/context/docker | ✓ cli/connhelper/ssh (4ms) | ✓ cli/connhelper (5ms) | ✓ cli/compose/loader (229ms) | ∅ cli/hints | ✓ cli/debug (2ms) | ✓ cli/flags (6ms) | ∅ cli/manifest/types | ∅ cli/registry/client | ∅ cli/streams | ✓ cli/manifest/store (11ms) | # github.com/docker/cli/cli-plugins/manager [github.com/docker/cli/cli-plugins/manager.test] | cli-plugins/manager/error_test.go:19:21: undefined: is.ErrorIs | ∅ cli/version | ∅ cli/winresources | ∅ cli-plugins/examples/helloworld | ✖ cli-plugins/manager | ∅ cli-plugins/plugin | ✓ cli/trust (8ms) | ✓ cli/context/store (236ms) | ∅ internal/test | ∅ internal/test/builders | ∅ internal/test/environment | ∅ internal/test/network | ∅ internal/test/notary | ∅ internal/test/output | ✓ service/logs (3ms) | ✓ templates (3ms) | ✓ opts (10ms) | ✓ cmd/docker (22ms) | ✓ cli/command/trust (11.602s) | | === Skipped | === SKIP: cli/command/container TestSplitCpArg/absolute_path_with_drive (0.00s) | cp_test.go:184: testcase.os != "" && testcase.os != runtime.GOOS | | === SKIP: cli/command/container TestRunLabel (0.00s) | run_test.go:21: DM - skipping dodgy test | | === SKIP: cli/command/image TestRunBuildResetsUidAndGidInContext (0.00s) | build_test.go:61: os.Getuid() != 0: root is required to chown files | | === SKIP: cli/command/image TestRunBuildFromGitHubSpecialCase (0.00s) | build_test.go:125: DM - disabled due to network access | | === SKIP: cli/command/trust TestSignCommandLocalFlag (0.00s) | sign_test.go:276: DM - skip test that fails | | === SKIP: cmd/docker TestBuildWithBuilder (0.00s) | builder_test.go:26: DM - skipping malfunctioning test, fails on sbuild | | === Failed | === FAIL: cli-plugins/manager (0.00s) | FAIL github.com/docker/cli/cli-plugins/manager [build failed] | | === FAIL: cli/connhelper/commandconn (0.00s) | FAIL github.com/docker/cli/cli/connhelper/commandconn [build failed] | | === Errors | cli/connhelper/commandconn/commandconn_unix_test.go:184:21: undefined: is.ErrorIs | cli/connhelper/commandconn/commandconn_unix_test.go:214:21: undefined: is.ErrorIs | cli-plugins/manager/error_test.go:19:21: undefined: is.ErrorIs ``` When using vendor version as in repository, the issue is not observed. The version available in Debian is: 3.0.3-1 While vendor version might be higher. Current latest version on go sources is around 3.5.1 I guess update of gotest.tools is needed on Debian. Kindly provide suggestions. Thanks & Regards, Badrikesh Prusty
