Hello General, thanks for the patches, details below.
On 04/06/2006 General Stone wrote: > In the attachment are patches for a better support on decrypted keys and > to fix some little typing errors. i didn't find any fixed typos, did you miss them in the patch? > 1) seperate the init-script and the decrypt-scripts so that anybody can > write his own decrypt-script without modify the init-script. The > decrypted key must be in "/tmp/cryptdisk.key" were it will be removed > after added a crypted disk. good idea, i will implement it soon. > 2) The swap-check-script use the "strings" tool which is in "/usr/bin" > :-/. "egrep" can work with binarys so that work with "strings" is > needless. also a good idea, but using vol_id from udev seems like a even better one. still the scripts could use a fallback, if udev is not installed. > 3) "/etc/keys" <-- which keys? better is "/etc/disk-keys"!? i don't see the point here. what's wrong with /etc/keys? i don't think that most people like a new directory for every key type. and it's only a recommentation, nobody is forced to store his/her keys there. ... jonas
signature.asc
Description: Digital signature
