On 27/11/2023 20:12, Vagrant Cascadian (@vagrant) wrote on salsa: >Thanks! Looks good to me, could you add (Closes: #XXX) on the first line of >the commit?
Hi Vagrant, Thanks for agreeing to the merge request. I've added the Closes: note. I just wanted to note while the bug is still open, that I was originally aiming to simplify the list of files for each arm64 sunxi board in targets.mk, and from my point of view u-boot-sunxi-with-spl.bin is the only one still needed. I know that you said earlier (on 25/07/2023 17:39 in the bug report): > I am also a bit inclined to adding u-boot-sunxi-with-spl.bin rather than > replacing all the other parts, as there are some use-cases (e.g. an > image capable of booting both sunxi and rockchip systems at different > offsets) where the individual parts are still needed. but I'm not sure that's right, because I believe sunxi-spl.bin and u-boot-sunxi-with-spl.fit.itb always need to be concatenated to work, because the SPL is hard-coded to look for U-Boot proper immediately after itself, as determined by spl_mmc_get_uboot_raw_sector() in arch/arm/mach-sunxi/board.c. So I think any "One image to rule them all" that arranged the parts differently would need a custom build, not the files currently in the Debian u-boot binary packages. That said, I'm happy to see u-boot-sunxi-with-spl.bin included, so thank you very much for doing that and all the other things that came up in this sprawling bug report. Best wishes, Harold.
