Package: dnssec-trigger Version: 0.17+repack-5.1 Severity: normal Tags: patch User: bi...@debian.org
Hi, your package currently installs a NetworkManager hook script in /etc/NetworkManager/dispatcher.d This practice is no longer recommended and instead package provided hook scripts should be moved to /usr/lib/NetworkManager/dispatcher.d /etc/NetworkManager/dispatcher.d is meant to be used for local modifications. Disabling a package provided hook script is as simple as running touch /etc/NetworkManager/dispatcher.d/$hookscriptname Overriding a packager provided hook can also be done by providing a script in /etc with the same name. Attached is a patch which updates dnssec-trigger to use this new scheme. Please consider it in your next upload. I can also offer to NMU the package with this change. Regards, Michael
diff -Nru dnssec-trigger-0.17+repack/debian/changelog dnssec-trigger-0.17+repack/debian/changelog --- dnssec-trigger-0.17+repack/debian/changelog 2023-05-11 19:40:04.000000000 +0200 +++ dnssec-trigger-0.17+repack/debian/changelog 2023-09-27 16:31:30.000000000 +0200 @@ -1,3 +1,11 @@ +dnssec-trigger (0.17+repack-5.2) UNRELEASED; urgency=medium + + * Non-maintainer upload. + * Move NetworkManager hook script to /usr/lib/NetworkManager/dispatcher.d. + (Closes: #-1) + + -- Michael Biebl <bi...@debian.org> Wed, 27 Sep 2023 16:31:30 +0200 + dnssec-trigger (0.17+repack-5.1) unstable; urgency=medium * Non-maintainer upload. diff -Nru dnssec-trigger-0.17+repack/debian/dnssec-trigger.maintscript dnssec-trigger-0.17+repack/debian/dnssec-trigger.maintscript --- dnssec-trigger-0.17+repack/debian/dnssec-trigger.maintscript 1970-01-01 01:00:00.000000000 +0100 +++ dnssec-trigger-0.17+repack/debian/dnssec-trigger.maintscript 2023-09-27 16:31:26.000000000 +0200 @@ -0,0 +1 @@ +rm_conffile /etc/NetworkManager/dispatcher.d/01-dnssec-trigger 0.17+repack-5.1 diff -Nru dnssec-trigger-0.17+repack/debian/rules dnssec-trigger-0.17+repack/debian/rules --- dnssec-trigger-0.17+repack/debian/rules 2020-08-24 20:24:56.000000000 +0200 +++ dnssec-trigger-0.17+repack/debian/rules 2023-09-27 16:31:30.000000000 +0200 @@ -20,6 +20,7 @@ --with-ssl \ --with-python=/usr/bin/python3 \ --with-hooks=networkmanager \ + --with-networkmanager-dispatch=/usr/lib/NetworkManager/dispatcher.d \ --with-gui=gtk \ --with-unitdir=/lib/systemd/system \ --with-rundir=/run \