Am 14.11.22 um 11:24 schrieb Hefee:
Hey,

Looking a second time with a deeper view on it, there is something more
under the hood to tune and adjust.

The cli.show_server_banner function from flask changed, that triggers the
issue.

Then the oninshare package would need to get adjustments too, for the potential and desired migration of Flask > 2.2 to final testing oninshare isn't a problem right now as it's not available in testing currently and should not block migrations.

I was thinking about raising the severity for this report but concluded it's currently not needed to increase the severity as the packages flask and python-werkzeug doesn't gain from such a bump.

But the "onionshare --help" tests fails because it cannot install onionshare
correctly. From my point of view it is more an issue for your testbed and I
cannot see the issue on onionshare side ( yet).

That's for sure possible, OTOH I don't wanted to dig much more deeper into this for now. Let's first get a recent flask version into testing, I'm sure some things will easier to solve then if we want to provide recent versions for Flask and python-werkzeug in a bookworm release.

--
Regards
Carsten

Reply via email to