Hi,
Am 08.11.22 um 13:02 schrieb Hefee:
Hey,
From my point of view it is an issue within flask-socketio and has
nothing to do with onionshare. > The import flask_socketio from onionshare
works. But than
flask-socketio fails to import werkzeug, so the problem is either
flask-socketio or werkzeug. As werkzeug and flask are updated in
experimental, I expect flask.socketio to be the problem. It seems
like flask-socketio 5.3.0 fixes this see Changes line 11: >
https://github.com/miguelgrinberg/Flask-SocketIO/blob/main/CHANGES.md
your investigation is right, thanks for figuring out!
I've simply imported a new version of flask-socketio and run the
autopkgtest suite of oninshare with the new version of flask-socketio.
The tests are running fine, except for
Test-Command: XDG_CONFIG_HOME="$AUTOPKGTEST_TMP" xvfb-run -- onionshare --help
Depends: onionshare, xvfb, xauth
Restrictions: allow-stderr, superficial,
Features: test-name=onionshare_help
which is failing.
autopkgtest [12:22:08]: @@@@@@@@@@@@@@@@@@@@ summary
onionshare-cli_help PASS (superficial)
share_files PASS
receive_files PASS
share_website PASS
chat_server PASS
onionshare_help FAIL badpkg
blame: arg:/build/onionshare-cli_2.5-2_all.deb deb:onionshare-cli
arg:/build/onionshare_2.5-2_all.deb deb:onionshare /build/onionshare-2.5
badpkg: Test dependencies are unsatisfiable. A common reason is that your
testbed is out of date with respect to the archive, and you need to use a
current testbed or run apt-get update or use -U.
The test in question is marked as superficial, so this non working test
shouldn't have any negative outcome like blocking the package on
migration. But it's up to the maintainers to decide how to handle this.
Could flask-socketio please be upgraded in unstable to the most recent
version?
--
Regards
Carsten
