Andree Leidenfrost said on Wed, May 03, 2006 at 07:29:25AM +1000: > Thank you very much for your feedback about the first patch! I shall > respond to it in detail including a fixed patch hopefully later today.
Okidoki (as someone I know generaly said ;-) > In the meantime please find attached a replacement for read_mdstat() > called parse_mdstat() which is a complete reimplementation of the former > that also adds support for the missing parameters (including multipath). > I have tested it with various RAID combinations and run it under > valgrind which says it's happy with. Valgrind is an excellent idea !! I planned that for trunk. > It also includes an updated mondostructures.h with fields added to the > RAID-related structures. I have not checked thus far whether there may > be side effects caused by this. I do hope that not. You can commit this one without issue I think. Does it break compatibility with previously made archives somehow ? If yes, we need to take extreme care, and update the major number of mondo. If not, everything is nice. I'd also like that you commit your modif on my-stuff.h. This is a nice one ;-) > Note that this is _only_ the routine to read mdstat. What is still > outstanding is adding support for the new parameters to the code that > writes and reads the raidtab file. I'll work on that next. Ok. > If you could have a look and let me know what you think (and maybe run > it on some systems that have RAID and check the output), that would be > great! My general remark is that I'd like to avoid as much as possible static allocation for future evolutions of mondo. So using asprintf, and no more malloc_string, MAX_STR_LEN and the like. Do not worry for the moment, but I'd like to edit the patch in that sense before inclusion. Thanks for the work ! Bruno. -- Linux Profession Lead EMEA / Open Source Evangelist \ HP C&I EMEA IET http://www.mondorescue.org / HP/Intel Solution Center \ http://hpintelco.net Des infos sur Linux? http://www.HyPer-Linux.org http://www.hp.com/linux La musique ancienne? http://www.musique-ancienne.org http://www.medieval.org
pgppOn51GwucP.pgp
Description: PGP signature
