Hi Bruno, On Fri, 2006-05-05 at 01:43 +0200, Bruno Cornec wrote: > Andree Leidenfrost said on Wed, May 03, 2006 at 07:29:25AM +1000: > > > Thank you very much for your feedback about the first patch! I shall > > respond to it in detail including a fixed patch hopefully later today. > > Okidoki (as someone I know generaly said ;-)
Hehe. ;-) > > In the meantime please find attached a replacement for read_mdstat() > > called parse_mdstat() which is a complete reimplementation of the former > > that also adds support for the missing parameters (including multipath). > > I have tested it with various RAID combinations and run it under > > valgrind which says it's happy with. > > Valgrind is an excellent idea !! I planned that for trunk. Yeah, it's much easier to run it on a freshly written small piece of code than on trunk. ;-) > > It also includes an updated mondostructures.h with fields added to the > > RAID-related structures. I have not checked thus far whether there may > > be side effects caused by this. I do hope that not. > > You can commit this one without issue I think. > Does it break compatibility with previously made archives somehow ? > If yes, we need to take extreme care, and update the major number of > mondo. If not, everything is nice. I have a little problem with getting the different drive types (i.e. normal, spare, parity, faulty) extracted correctly. Looking into this further, I currently think I might axe structure s_mdstat and fill raidlist directly in parse_mdstat(). > I'd also like that you commit your modif on my-stuff.h. This is a nice > one ;-) Righto. > > Note that this is _only_ the routine to read mdstat. What is still > > outstanding is adding support for the new parameters to the code that > > writes and reads the raidtab file. I'll work on that next. > > Ok. I've worked somewhat more on this. Maybe I have something ready by the end of the weekend. > > If you could have a look and let me know what you think (and maybe run > > it on some systems that have RAID and check the output), that would be > > great! > > My general remark is that I'd like to avoid as much as possible static > allocation for future evolutions of mondo. So using asprintf, and no > more malloc_string, MAX_STR_LEN and the like. > > Do not worry for the moment, but I'd like to edit the patch in that > sense before inclusion. Well, I really want to get the hang of safer string handling, so I'll try and look into this as well. > Thanks for the work ! No worries. I wish it was going faster, but I have quite limited time at the moment. > Bruno. Cheers, Andree -- Andree Leidenfrost Sydney - Australia
signature.asc
Description: This is a digitally signed message part
