Mattia Rizzolo wrote:
>> * It's unclear whether this fits the semantics of the TERM signal.
>> As you yourself ask in your reply, it is unclear whether
>> diffoscope *should* actually do this. (If I were on the command-line
>> and hit CTRL+C, I'm not entirely sure I'd want it to stop performing
>> a diff and start opening files to write HTML...)
>
> Right. That's exactly why I also mentioned other signals, which might
> have better semantics for this case (like, HUP, which nowadays is pretty
> much process-specific).
>
> (besides, doesn't CTRL+C send INT, not TERM?)
(Yes, whoops, you are absolutely right.)
>> * It's all a bit of a workaround to "diffoscope being slow". Or, rather,
>> there are higher-priority things that will avoid us reaching the
>> timeout in the first place. (For instance, improving the overall
>> speed of ELF handling.)
>
> But I agree with this, so my musing above are probably better discarded
> at this time, and consider this bug closed :)
Yes, I should say so. Please go ahead...
Best wishes,
--
o
⬋ ⬊ Chris Lamb
o o reproducible-builds.org 💠
⬊ ⬋
o
