On Wed, Jun 08, 2022 at 01:15:17PM +0100, Chris Lamb wrote: > > Oh, yes, that's probably what it ought to do indeed (logging that it > > received a signal and leave some traces of itself on stdout, at least). > > Hm, by "leave some traces of itself on stdout", what exactly do you > mean by that? You appear to be implying it should do more than simply > logging it has received a signal and is cleaning up after itself?
Sorry for being unclear. I meant that what you commit is exactly what
it should have done from the start. Currently (before your commits)
diffoscope would not print anything out after receiving TERM, save from
some .debug() output about cleaning up temp files (which are not printed
by default).
> * It's unclear whether this fits the semantics of the TERM signal.
> As you yourself ask in your reply, it is unclear whether
> diffoscope *should* actually do this. (If I were on the command-line
> and hit CTRL+C, I'm not entirely sure I'd want it to stop performing
> a diff and start opening files to write HTML...)
Right. That's exactly why I also mentioned other signals, which might
have better semantics for this case (like, HUP, which nowadays is pretty
much process-specific).
(besides, doesn't CTRL+C send INT, not TERM?)
> * It's all a bit of a workaround to "diffoscope being slow". Or, rather,
> there are higher-priority things that will avoid us reaching the
> timeout in the first place. (For instance, improving the overall
> speed of ELF handling.)
But I agree with this, so my musing above are probably better discarded
at this time, and consider this bug closed :)
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
More about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature
