Package: firefox
Version: 1.5.dfsg+1.5.0.2-2
Severity: normal
Tags: patch

I have profile that named "Default User".
But Firefox cannot handles such profile name correctly.


For example, When I try to run the firefox with "Default User" profile:
$ firefox -V -P "Default User"
FIREFOX_DSP=
APPLICATION_ID=firefox--Default User
CMDLINE_DISPLAY=
DISPLAY=:0.0
OPTIONS=-P Default User
DEBUG=0
DEBUGGER=
Running: /usr/lib/firefox/firefox-bin -a firefox--Default User -P Default User

And then it will try to open "http://User/";.
A space character in "Default User" is treated as word delimiter by shell.

This problem is due to the wrong handling of ${APPLICATION_ID} variable.

Currently, firefox command uses following code to append "-a ${APPLICATION_ID}"
arguments.
 MOZ_PROGRAM="${MOZ_PROGRAM} -a ${APPLICATION_ID}"

However, appending "-a ${APPLICATION_ID}" in this way will occurs Word 
Splitting.
All spaces(" ") in ${APPLICATION_ID} is treated as word delimiter.

Above code should be write as:
 set "$@" "-a" "${APPLICATION_ID}"


I have attached a patch to fix this problem.


Sorry for my inaccurate English.

thanks,

Morita Sho

--- firefox.orig        2006-04-24 09:18:04.000000000 +0900
+++ firefox     2006-04-24 09:18:14.000000000 +0900
@@ -239,6 +239,8 @@
     fi
 done

+set "$@" "-a" "${APPLICATION_ID}"
+
 if [ $# -ne 0 ]; then
     shift
 fi
@@ -249,7 +251,7 @@
         DEBUGGER=gdb
     fi
     TMPFILE=`mktemp -t firefox_argsXXXXXX`
-    echo set args -a ${APPLICATION_ID} "$@" > ${TMPFILE}
+    echo set args "$@" > ${TMPFILE}
     case "${DEBUGGER}" in
         gdb)
             run_verbose gdb "${MOZ_PROGRAM}" -x ${TMPFILE}
@@ -265,7 +267,6 @@
     exit
 fi

-MOZ_PROGRAM="${MOZ_PROGRAM} -a ${APPLICATION_ID}"

 echo_vars FIREFOX_DSP APPLICATION_ID CMDLINE_DISPLAY DISPLAY \
           OPTIONS DEBUG DEBUGGER



-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.16-1-k7
Locale: LANG=ja_JP.UTF-8, LC_CTYPE=ja_JP.UTF-8 (charmap=UTF-8)

Versions of packages firefox depends on:
ii  debianutils                 2.15.7       Miscellaneous utilities specific t
ii  fontconfig                  2.3.2-5.1    generic font configuration library
ii  libatk1.0-0                 1.11.4-1     The ATK accessibility toolkit
ii  libc6                       2.3.6-7      GNU C Library: Shared libraries
ii  libcairo2                   1.0.4-1+b1   The Cairo 2D vector graphics libra
ii  libfontconfig1              2.3.2-5.1    generic font configuration library
ii  libfreetype6                2.1.10-3     FreeType 2 font engine, shared lib
ii  libgcc1                     1:4.1.0-1+b1 GCC support library
ii  libglib2.0-0                2.10.2-1     The GLib library of C routines
ii  libgtk2.0-0                 2.8.17-1     The GTK+ graphical user interface
ii  libidl0                     0.8.6-1      library for parsing CORBA IDL file
ii  libjpeg62                   6b-12        The Independent JPEG Group's JPEG
ii  libpango1.0-0               1.12.1-2     Layout and rendering of internatio
ii  libpng12-0                  1.2.8rel-5.1 PNG library - runtime
ii  libstdc++6                  4.1.0-1+b1   The GNU Standard C++ Library v3
ii  libx11-6                    2:1.0.0-6    X11 client-side library
ii  libxcursor1                 1.1.5.2-5    X cursor management library
ii  libxext6                    1:1.0.0-4    X11 miscellaneous extension librar
ii  libxfixes3                  1:3.0.1.2-4  X11 miscellaneous 'fixes' extensio
ii  libxft2                     2.1.8.2-6    FreeType-based font drawing librar
ii  libxi6                      1:1.0.0-5    X11 Input extension library
ii  libxinerama1                1:1.0.1-4    X11 Xinerama extension library
ii  libxrandr2                  2:1.1.0.2-4  X11 RandR extension library
ii  libxrender1                 1:0.9.0.2-4  X Rendering Extension client libra
ii  libxt6                      1:1.0.0-4    X11 toolkit intrinsics library
ii  psmisc                      22.2-1       Utilities that use the proc filesy
ii  zlib1g                      1:1.2.3-11   compression library - runtime

firefox recommends no packages.

-- no debconf information



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to