tags 364566 pending
thanks

I just surrounded the reference to the variable in single quotes
instead.  

* Morita Sho ([EMAIL PROTECTED]) wrote:
> Package: firefox
> Version: 1.5.dfsg+1.5.0.2-2
> Severity: normal
> Tags: patch
> 
> I have profile that named "Default User".
> But Firefox cannot handles such profile name correctly.
> 
> 
> For example, When I try to run the firefox with "Default User" profile:
> $ firefox -V -P "Default User"
> FIREFOX_DSP=
> APPLICATION_ID=firefox--Default User
> CMDLINE_DISPLAY=
> DISPLAY=:0.0
> OPTIONS=-P Default User
> DEBUG=0
> DEBUGGER=
> Running: /usr/lib/firefox/firefox-bin -a firefox--Default User -P Default User
> 
> And then it will try to open "http://User/";.
> A space character in "Default User" is treated as word delimiter by shell.
> 
> This problem is due to the wrong handling of ${APPLICATION_ID} variable.
> 
> Currently, firefox command uses following code to append "-a 
> ${APPLICATION_ID}"
> arguments.
>  MOZ_PROGRAM="${MOZ_PROGRAM} -a ${APPLICATION_ID}"
> 
> However, appending "-a ${APPLICATION_ID}" in this way will occurs Word 
> Splitting.
> All spaces(" ") in ${APPLICATION_ID} is treated as word delimiter.
> 
> Above code should be write as:
>  set "$@" "-a" "${APPLICATION_ID}"
> 
> 
> I have attached a patch to fix this problem.
> 
> 
> Sorry for my inaccurate English.
> 
> thanks,
> 
> Morita Sho
> 
> --- firefox.orig      2006-04-24 09:18:04.000000000 +0900
> +++ firefox   2006-04-24 09:18:14.000000000 +0900
> @@ -239,6 +239,8 @@
>      fi
>  done
> 
> +set "$@" "-a" "${APPLICATION_ID}"
> +
>  if [ $# -ne 0 ]; then
>      shift
>  fi
> @@ -249,7 +251,7 @@
>          DEBUGGER=gdb
>      fi
>      TMPFILE=`mktemp -t firefox_argsXXXXXX`
> -    echo set args -a ${APPLICATION_ID} "$@" > ${TMPFILE}
> +    echo set args "$@" > ${TMPFILE}
>      case "${DEBUGGER}" in
>          gdb)
>              run_verbose gdb "${MOZ_PROGRAM}" -x ${TMPFILE}
> @@ -265,7 +267,6 @@
>      exit
>  fi
> 
> -MOZ_PROGRAM="${MOZ_PROGRAM} -a ${APPLICATION_ID}"
> 
>  echo_vars FIREFOX_DSP APPLICATION_ID CMDLINE_DISPLAY DISPLAY \
>            OPTIONS DEBUG DEBUGGER

-- 
Eric Dorland <[EMAIL PROTECTED]>
ICQ: #61138586, Jabber: [EMAIL PROTECTED]
1024D/16D970C6 097C 4861 9934 27A0 8E1C  2B0A 61E9 8ECF 16D9 70C6

-----BEGIN GEEK CODE BLOCK-----
Version: 3.12
GCS d- s++: a-- C+++ UL+++ P++ L++ E++ W++ N+ o K- w+ 
O? M++ V-- PS+ PE Y+ PGP++ t++ 5++ X+ R tv++ b+++ DI+ D+ 
G e h! r- y+ 
------END GEEK CODE BLOCK------

Attachment: signature.asc
Description: Digital signature

Reply via email to