Hi Simon,

If you are happy with this change, please say so, and I can move the upload
out of the DELAYED queue and into unstable immediately.

Thanks a lot! Yes I am happy with the change.

I am unsure whether the release team will be willing to unblock with the
two commits cherry-picked from upstream git included in the package. If
they are not, another upload that additionally reverts one or both of
those commits might be necessary. We are less likely to need to revert
them if we can justify why they are required.

d/p/GIT-fix-adsp_se.patch looks like it might be fixing a genuine bug. Can
you describe the bug that it is fixing and why it should be applied in
bullseye?

d/p/GIT-fix-compiler-warnings.patch looks like it is just silencing
compiler warnings by removing unreachable code. Do we really need this
for bullseye? If it is not strictly necessary then it might be safer to
revert it until after bullseye has been released.

Those changes were suggested for inclusion by Sébastien (CC'ed). I don't know more about them than what it says in the patch files. They both come from upstream osspd git.

After bullseye is released and the freeze is over, you can reapply the
changes that I've reverted and upload to unstable in the usual way.

So, the recommended way is that I pull your changes into my git repo, and then apply reverts of the reverts? Sure, works for me.

Thanks for maintaining osspd,

Btw, I'm not using osspd any more, and I am not very skilled with Debian packaging tools since all I do with them is upload a new osspd release every 2 years or so. So help would be welcome. :)

Kind regards,
Ralf

Reply via email to