Jonas

Rest assured I "removed lines"

What I did: 

 * Knock-out incorrect package description lines.
 * Keep copyright parsing python code as is
 * Keep encouraging statement in template file to use licensecheck

Sorry for my confusing message :-)

I didn't go for "different" thinking that I may make debmake to call
licensecheck in future.

On Sun, 2020-07-05 at 17:03 +0200, Jonas Smedegaard wrote:
> Quoting Osamu Aoki (2020-07-05 16:25:40)
> > Control: tags -1 pending
> > 
> > (Patch commuted to salsa.)
> > 
> > Yes your updated licensecheck is as good in functionality with
> > 
> >  --deb-machine
> > 
> > option!  This is incorrect.
> > 
> > I admit my script has some shortcomings.  But I also realize
> > replacing
> > it with your licensecheck doesn't solve this.  So I will keep it as
> > is
> > while urging people to use licensecheck in generated template file.
> 
> You mean that you will keep the package description as-is?
> 
> Please consider _reprhasing_ (not removing), to avoid users
> misreading 
> it as debmake being a superset of licensecheck which is not true.
> 
> Concretely, I propose to replace the word "more" with the word 
> "different".
> 
> 
>  - Jonas
> 
From 8aa67476b1a053d669e284ed66e7c01f76fc21ba Mon Sep 17 00:00:00 2001
From: Osamu Aoki <os...@debian.org>
Date: Sun, 5 Jul 2020 23:09:07 +0900
Subject: [PATCH 1/2] Update package description

Drop incorrect statement on licensecheck.

Signed-off-by: Osamu Aoki <os...@debian.org>
---
 debian/changelog | 5 ++++-
 debian/control   | 1 -
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index d4cd4e1..a51fccb 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,7 +4,10 @@ debmake (4.3.2-1) UNRELEASED; urgency=medium
   * d/changelog: Remove trailing whitespaces
 
   [VictorRodriguez]
-  *  Warning instead of error debmake fail due to missing shebang in setup.py
+  * Warning instead of error debmake fail due to missing shebang in setup.py
+
+  [ Osamu Aoki ]
+  * Drop incorrect statement on licensecheck.  Closes: #953724
 
  -- vmrod <vm.ro...@gmail.com>  Mon, 06 May 2019 15:29:40 -0500
 
diff --git a/debian/control b/debian/control
index ef4dfe8..739eee5 100644
--- a/debian/control
+++ b/debian/control
@@ -47,4 +47,3 @@ Description: helper script to make the Debian source package
  .
  This debmake command also scans copyright and license texts in the source
  files to help crafting the proper DEP-5 compatible debian/copyright file.
- It does more than what licensecheck(1) offers.
-- 
2.20.1

Reply via email to