Package: qemu
Version: 1:5.0-5
Hi,
I was wondering about Lintian errors in 5.x builds:
W: qemu-user: embedded-javascript-library
usr/share/doc/qemu-user/user/_static/jquery.js please use libjs-jquery
W: qemu-user: embedded-javascript-library
usr/share/doc/qemu-user/user/_static/underscore.js please use
libjs-underscore
W: qemu-user-static: embedded-javascript-library
usr/share/doc/qemu-user-static/user/_static/jquery.js please use
libjs-jquery
W: qemu-user-static: embedded-javascript-library
usr/share/doc/qemu-user-static/user/_static/underscore.js please use
libjs-underscore
We had this warning for a while for the same files in qemu-system-common,
but why on these packages as well now.
The path referenced is similar to doc-base:
./usr/share/doc/qemu-system-common/system
It now correctly has docs again, thanks to your recent changes:
54e01ee42a install qemu-system docs in qemu-system-common, not
qemu-system-data, as docs requires ./configure run
346306d1e0 add html docs to qemu-system-data (to
/usr/share/doc/qemu-system-common)
But on top more packages have got the same/similar docs installed in other
paths.
In particular qemu-user* has usr/share/doc/qemu-user/user/_static.
This is installed by the following in d/rules entry:
dh_installdocs -a -Nqemu-user-binfmt
When running verbose I can see:
$ ll debian/qemu-user-static/usr/share/doc/qemu-user-static/user/
debian/qemu-user/usr/share/doc/qemu-user/user/
ls: cannot access
'debian/qemu-user-static/usr/share/doc/qemu-user-static/user/': No such
file or directory
ls: cannot access 'debian/qemu-user/usr/share/doc/qemu-user/user/': No such
file or directory
$ dh_installdocs -a -Nqemu-user-binfmt -v
cd './debian/tmp/usr/share/doc/qemu/user/..' && find 'user' \(
-type f -or -type l \) -and ! -empty -print0 | LC_ALL=C sort -z | xargs -0
-I {} cp --reflink=auto --parents -dp {}
/build/qemu-ZGgsdt/qemu-5.0/debian/qemu-user/usr/share/doc/qemu-user
...
cd './debian/tmp/usr/share/doc/qemu/user/..' && find 'user' \(
-type f -or -type l \) -and ! -empty -print0 | LC_ALL=C sort -z | xargs -0
-I {} cp --reflink=auto --parents -dp {}
/build/qemu-ZGgsdt/qemu-5.0/debian/qemu-user-static/usr/share/doc/qemu-user-static
$ ll debian/qemu-user-static/usr/share/doc/qemu-user-static/user/
debian/qemu-user/usr/share/doc/qemu-user/user/
... lists content that was installed
The `qemu-user` and `qemu-user-static` docs installed by that would not
really fit in qemu-system-common where the other docs are.
So what to do?
a) keep them as is (few docs in the binary packages, slight duplication)
b) filter out docs on install, the following would do
dh_installdocs -a -Nqemu-user-binfmt --exclude doc
or also
dh_installdocs -a -Nqemu-user-binfmt --exclude user
I'm unsure if this might by accident filter too much, it doesn't atm but
maybe in future.
c) clean paths from d/rules after dh_installdocs has run
d) re-org these (or all) docs
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
