Quoting Sandro Mani (2020-02-24 12:04:34) > On 24.02.20 11:58, Jonas Smedegaard wrote: > > Quoting Sandro Mani (2020-02-24 10:12:50) > >> Since I need to update the package in Fedora (it is currently broken), > >> I've prepared the patch below to remove the dependency. Can you > >> perhaps confirm that it does not fundamentally break licensecheck in > >> some way? > >> From my tests, it appears to work. > > Uhm, it won't _fundamentally_ break, but it will find multiple related > > licenses where only one exist - e.g. detect fulltext of AGPL as either > > AGPL or GPL because it mentions GPL. > Thanks, that explains the one test failure I'm seeing.
Oh, so I _do_ include a test revealing that. Sorry, I am aware that the
included testsuite doesn't have full coverage. :-/
> > If you do choose to carry this patch, then I kindly request that you
> > document clearly that you are effectively distributing a fork of the
> > code, so that your users do not get the false impression that the
> > quality of your licensecheck is on par with that of licensecheck
> > released by me.
> I just need a short-term solution to get licensecheck working again
> (currently it is completely broken). If there are better solutions,
> I'm happy to go for whatever works!
Here are some options I can see:
* Roll back to an older release not depending on Array::IntSpan
(and roll back Regexp::Pattern::License as well)
* Wait for me to find a replacement for Array::IntSpan
* Apply your patch and document its deficiencies as I request above
> > I _do_ intend to fix this issue, just haven't gotten around to it
> > yet, and a proper fix involved _replacing_ Array::IntSpan, not
> > simply stripping it.
>
> Thanks, unfortunately my perl knowledge is pretty much zero, so sorry
> for not being able to help more.
I can relate to that: Sounds like me when dealing with Python :-)
- Jonas
--
* Jonas Smedegaard - idealist & Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
signature.asc
Description: signature
