Hi Sandro, Quoting Sandro Mani (2020-02-24 10:12:50) > Since I need to update the package in Fedora (it is currently broken), > I've prepared the patch below to remove the dependency. Can you > perhaps confirm that it does not fundamentally break licensecheck in > some way? > From my tests, it appears to work.
Uhm, it won't _fundamentally_ break, but it will find multiple related licenses where only one exist - e.g. detect fulltext of AGPL as either AGPL or GPL because it mentions GPL. If you do choose to carry this patch, then I kindly request that you document clearly that you are effectively distributing a fork of the code, so that your users do not get the false impression that the quality of your licensecheck is on par with that of licensecheck released by me. I _do_ intend to fix this issue, just haven't gotten around to it yet, and a proper fix involved _replacing_ Array::IntSpan, not simply stripping it. Kind regards, and thanks for caring about this, - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private
signature.asc
Description: signature
