Le 25/11/2018 à 22:39, Xavier a écrit :
> On Sun, 25 Nov 2018, Raphael Hertzog wrote:
>> On Thu, 22 Nov 2018, Xavier wrote:
>>> Last .deb contains the SALSA_RENAME_HEAD. Could you test it ?
>>
>> I wanted to do some test but something else broke:
>>
>> $ salsa --conf-file +./salsa-pkg-security.conf update_safe sandsifter
>> --verbose --debug
>> salsa info: Project sandsifter => pkg-security-team/sandsifter
>> salsa info: pkg-security-team/sandsifter id is 30154
>> sandsifter:
>> bad description: x86 processor fuzzer
>> 1 packages misconfigured, update them ? (Y/n)
>> salsa info: Project sandsifter => pkg-security-team/sandsifter
>> salsa info: Configuring sandsifter
>> salsa warn: The #1 argument ($project_id) to project must be a scalar at
>> /usr/share/perl5/Devscripts/Salsa/update_repo.pm line 49.
>
> Here is the fix, I'm building a new .deb:
>
> diff --git a/lib/Devscripts/Salsa/update_repo.pm
> b/lib/Devscripts/Salsa/update_repo.pm
> index 316baec9..3d637a72 100644
> --- a/lib/Devscripts/Salsa/update_repo.pm
> +++ b/lib/Devscripts/Salsa/update_repo.pm
> @@ -46,7 +46,7 @@ sub _update_repo {
> my $project;
> # 1 - creates new branch if --rename-head
> if ($self->config->rename_head) {
> - my $project = $self->api->project($_[0]);
> + my $project = $self->api->project($_->[0]);
> if ($project->{default_branch} ne
> $self->config->dest_branch) {
> $self->api->create_branch(
> $id,
> @@ -57,7 +57,7 @@ sub _update_repo {
> $configparams->{default_branch}
> = $self->config->dest_branch;
> } else {
> - ds_verbose "Head already renamed for $_[1]";
> + ds_verbose "Head already renamed for $_->[1]";
> $project = undef;
> }
> }
My last change produces this bug. Fixed now, I pushed a new .deb in the
same place.
Thanks for this report!
