On Thu, 22 Nov 2018, Raphael Hertzog wrote: > wapiti: > bad irc channel: #debian-pkg-security
Even after changing the setting, I still had the message for a few packages where the exact value was "#debian-pkg-security " (trailing space). I don't know if you want to strip the spaces before comparison but at the very least you might want to add some quotes to the error message so that it's clear that the difference comes from a trailing space. Since everything looked fine, I ran "update_repo" but was disappointed to see that it did change things even on packages that were fine: $ salsa --conf-file +./pkg-security.conf check_repo --verbose --all salsa info: Found 220 projects [...] salsa info: sandsifter: OK [...] $ salsa --conf-file +./pkg-security.conf update_repo --verbose --all You're going to configure 220 projects, continue (N/y)?y [...] salsa info: Configuring sandsifter salsa warn: Deleting old irker (redirected to #debian-pkg-security) salsa info: Irker hook added to project 30154 (channel: debian-pkg-security) salsa warn: Deleting old email-on-push (redirected to dispa...@tracker.debian.org) salsa info: Email-on-push hook added to project 30154 (recipients: dispa...@tracker.debian.org) salsa warn: Deleting old tagpending (was https://webhook.salsa.debian.org/tagpending/sandsifter) salsa info: Tagpending hook added to project 30154 salsa info: Project 30154 updated Worried by this, I pressed CTRL+C in the middle and the script was interrupted after a "Deleting old tagpending" (but before the corresponding "Tagpending hook added"), maybe we could catch the kill request and stop gracefully between two packages ? Then in the list of packages, I had "forensic-artifacts" which was using "master" and not "debian/master" and it didn't detect the problem and did not solve it either. I see the manual page doesn't mention any variable name for the --rename-head option. I tried to guess the name and I have put this in the configuration file: SALSA_SOURCE_BRANCH=master SALSA_DEST_BRANCH=debian/master SALSA_RENAME_HEAD=yes But it doesn't seem to do the trick. Is there a reason for this behaviour? However when I run check_repo with the command line option, then it sees the problem: $ salsa --conf-file +./pkg-security.conf check_repo --verbose --rename-head pkg-security-team/forensic-artifacts salsa info: pkg-security-team/forensic-artifacts id is 29265 pkg-security-team/forensic-artifacts: Default branch is master Then I ran the update_repo command and it didn't say anything about the fact that it was fixing the default branch: $ salsa --conf-file +./pkg-security.conf update_repo --verbose --rename-head pkg-security-team/forensic-artifacts salsa info: pkg-security-team/forensic-artifacts id is 29265 salsa info: Configuring pkg-security-team/forensic-artifacts salsa warn: Deleting old irker (redirected to #debian-pkg-security) salsa info: Irker hook added to project 29265 (channel: debian-pkg-security) salsa warn: Deleting old email-on-push (redirected to dispa...@tracker.debian.org) salsa info: Email-on-push hook added to project 29265 (recipients: dispa...@tracker.debian.org) salsa warn: Deleting old tagpending (was https://webhook.salsa.debian.org/tagpending/forensic-artifacts) salsa info: Tagpending hook added to project 29265 salsa info: Project 29265 updated But the change was well done (I verified it on the web interface). Cheers, -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: https://www.freexian.com/services/debian-lts.html Learn to master Debian: https://debian-handbook.info/get/
