Control: tags -1 patch pending

--

Hi,

it seems there are a few issues on architectures where char is unsigned
by default where the code make assumption that char is signed.
So here is a patch to fix this which I could test successfully on
ppc64*. I guess this could benefit to other arches :
https://wiki.debian.org/ArchitectureSpecificsMemo#Summary


F.
diff -Nru eclipse-titan-6.3.1/debian/patches/fix-unsigned-short-issues.patch 
eclipse-titan-6.3.1/debian/patches/fix-unsigned-short-issues.patch
--- eclipse-titan-6.3.1/debian/patches/fix-unsigned-short-issues.patch  
1970-01-01 01:00:00.000000000 +0100
+++ eclipse-titan-6.3.1/debian/patches/fix-unsigned-short-issues.patch  
2018-02-20 11:03:04.000000000 +0100
@@ -0,0 +1,42 @@
+Description: Fix #863142 
+Author: Frédéric Bonnard <fre...@debian.org>
+
+Index: eclipse-titan-6.3.1/xsdconvert/converter.cc
+===================================================================
+--- eclipse-titan-6.3.1.orig/xsdconvert/converter.cc   2017-12-05 
08:45:55.000000000 +0000
++++ eclipse-titan-6.3.1/xsdconvert/converter.cc        2018-11-07 
13:55:30.350145036 +0000
+@@ -71,7 +71,7 @@
+ 
+   // The file holding a list of the XSD files.
+   const char *from_file = NULL;
+-  char c;
++  signed char c;
+   opterr = 0;
+ 
+   while ((c = getopt(argc, argv, "cdef:ghJ:mnpqstvwxz")) != -1) {
+Index: eclipse-titan-6.3.1/core/Charstring.cc
+===================================================================
+--- eclipse-titan-6.3.1.orig/core/Charstring.cc        2017-12-05 
08:45:55.000000000 +0000
++++ eclipse-titan-6.3.1/core/Charstring.cc     2018-11-07 13:54:54.937282874 
+0000
+@@ -1344,7 +1344,7 @@
+ * Translates a Base64 value to either its 6-bit reconstruction value
+ * or a negative number indicating some other meaning.
+ * Public domain from http://iharder.net/base64 */
+-char  base64_decoder_table[256] =
++signed char  base64_decoder_table[256] =
+ {
+   -9,-9,-9,-9,-9,-9,-9,-9,-9,                 // Decimal  0 -  8
+   -5,-5,                                      // Whitespace: Tab and Linefeed
+Index: eclipse-titan-6.3.1/core/Universal_charstring.cc
+===================================================================
+--- eclipse-titan-6.3.1.orig/core/Universal_charstring.cc      2017-12-05 
08:45:55.000000000 +0000
++++ eclipse-titan-6.3.1/core/Universal_charstring.cc   2018-11-07 
14:03:33.385683772 +0000
+@@ -2075,7 +2075,7 @@
+ static char
+ in_word_set (const char *str, unsigned int len)
+ {
+-  static char wordlist[] =
++  static signed char wordlist[] =
+     {
+       -1, -1,
+       12, // FF
diff -Nru eclipse-titan-6.3.1/debian/patches/series 
eclipse-titan-6.3.1/debian/patches/series
--- eclipse-titan-6.3.1/debian/patches/series   1970-01-01 01:00:00.000000000 
+0100
+++ eclipse-titan-6.3.1/debian/patches/series   2018-02-20 11:03:04.000000000 
+0100
@@ -0,0 +1 @@
+fix-unsigned-short-issues.patch

Attachment: pgpMeD63izVJV.pgp
Description: PGP signature

Reply via email to