Le 10 juillet 2018 23:54:31 GMT+02:00, "László Böszörményi (GCS)" <g...@debian.org> a écrit : >Hi, > >On Mon, Jul 9, 2018 at 2:12 PM Pierre-Elliott Bécue <be...@crans.org> >wrote: >> Le dimanche 08 juillet 2018 à 19:35:13+0200, László Böszörményi (GCS) >a écrit : >> > On Sun, Jul 8, 2018 at 5:51 PM Pierre-Elliott Bécue ><be...@crans.org> wrote: >> > > I've prepared an NMU for python-gevent (versioned as 1.3.4-0.1), >to fix >> > > those three RC bugs. The diff is there[1]. >> > I'll check it. I've already packaged 1.3.4 locally, but has an >> > upstream bug or it seems at least. That needs checking. >> >> I added two new commits to make my changes more fit to Debian's >standards, >> please have a look at the salsa repository. :) If you wish, I can >update my >> diff file. > I do not get your point, what's funny in that you committed even more >to the repository without asking. But read on. > >> I succeed at building & installing & importing the module on a >minimal >> container. > I couldn't do it in my minimal environment. But then just left your >package version without checking the build failure. > >> > > It'll soon (in a matter of days) be uploaded to DELAYED/5 (it's a >new >> > > upstream release, so I'd rather give you some time to answer if >you feel it >> > > necessary), provided my current mentor's review comes with no >issue. > May I ask you who is that mentioned 'mentor'? What I see is that you >messed up everything big. Worse that you committed your changes to Git >on Salsa. >Some points that you and your 'mentor' missed and come to my mind: >- minimal Python 3 version is 3.4 now, >- there's a two newer debhelper compatibility level, >- there's a five newer standards-version, >- autotools-dev build dependency is outdated, >- parallel no longer need to be specified, >- you patch conf.py when there's an existing PYTHONPATH to set for an >easier solution, >- JavaScript symlinks is no longer needed, >- privacy breaches protection had to be updated, >- if you about to install everything, then why do you ignore the CFFI >build for example, >- the packaging had to be updated to keep it rebuildable, >- ... > >Laszlo/GCS
This is my repository in my name space. I consider myself allowed to commit in here any time I wish to. Your repository (which is not linked anywhere by the way) is not impacted and the only purpose of the previously mentioned salsa repo is to give you a clean mean to see the changes I offer. Changes that are designed only to fix the three RC bugs of gevent that are currently open and preventing this package to work. If you wish me to clean the package a little more, feel free to ask. I'll answer to the specific remarks of your message tomorrow. Regards. -- PEB
