On Tue, May 15, 2018 at 5:19 AM, Simon McVittie <s...@debian.org> wrote:

> On Tue, 15 May 2018 at 08:46:24 +0000, z...@debian.org wrote:
> >   * Apply debdiff from Ubuntu (Closes: #898663):
> >     - d/p/fix-test-run.py.patch: Dropped. No longer needed.
>
> This part seemed OK, but the changelog is a bit misleading: "no longer
> applied since x.y.z" would perhaps be better?
>
>
I don't know that I'd call this changelog message misleading. With the
current package version, the tests now run successfully without this patch.


> >     - d/tests/control: Drop python-testscenarios from Depends.
> >     - d/tests/testsuite-*: Set PYTHONPATH when running tests.
>
> As discussed on the bug, these two points seem to be invalid. Please
> revert those changes.
>
>
Yes, agreed.

Thanks,
Corey


>     smcv
>
>

Reply via email to