On Mon, 14 May 2018 at 14:36:22 -0400, Corey Bryant wrote:
> In Ubuntu, the attached patch was applied to achieve the following
(Not a maintainer of this particular package, just a team subscriber)
Thanks for your patch, but I think it indicates some misunderstandings
of autopkgtest; I'm hoping that by replying quickly, I can reduce delta
in Ubuntu packages other than this one, and avoid changes being upstreamed
back into Debian that shouldn't have been.
> - d/tests/testsuite-*: Set PYTHONPATH when running tests.
Does this result in the version of testtools from the unpacked source
package being tested? If so, then it defeats one of the purposes of
autopkgtest (and one of the things that separates autopkgtests from
build-time testing), which is to test what is installed on the system
(for example in /usr/lib/python3/dist-packages).
If I modified testtools so that python3-testtools no longer contained
/usr/lib/python3/dist-packages, or the equivalent for python-testtools,
that should make it fail its autopkgtests. One of the things the
autopkgtests should be exercising is that the binary packages are not
empty, incorrectly structured or otherwise unusable. If you load the code
under test from the source package, then that won't be checked.
The autopkgtest seems to pass in Debian, so why was this change made?
If you are proposing a change, one of the things it should include is
why the change is desirable.
> - d/control: Enable execution of autopkgtests.
...
> +XS-Testsuite: autopkgtest
This part is unnecessary. dpkg-dev in Debian stable automatically detects
Testsuite: autopkgtest from the existence of debian/tests/control,
and the XS- prefix hasn't been needed since before oldstable.
> - d/tests/control: Drop python-testscenarios from Depends.
Again, please say why - if not in the changelog, then in the request to
make changes in Debian. This change makes sense, if python-testscenarios
is no longer used. However, if it is still used, and test coverage is
reduced (tests are skipped) without it, then it should not be dropped. I
don't know this particular package, so I can't say which one is true.
> - d/p/fix-test-run.py.patch: Dropped. No longer needed.
This part seems to make sense, although the changelog entry is a little
misleading: the patch already wasn't being applied.
Thanks,
smcv
