Package: wicd-curses
Version: 1.7.4+tb2-5
Followup-For: Bug #814090
I have been experiencing this bug for a while now, and decided to have a look at
the implementation. I came up with the following fix (I have no idea if this
introduces other issues but wicd-curses has been quite stable for me after
I applied this patch):
--start_of_patch--
diff --git a/curses/curses_misc.py b/curses/curses_misc.py
index a8b94f7..93c12cb 100644
--- a/curses/curses_misc.py
+++ b/curses/curses_misc.py
@@ -461,7 +461,7 @@ class ComboBox(urwid.WidgetWrap):
self.cbox = DynWrap(SelText([self.list[index] + self.DOWN_ARROW]),
attrs=self.attrs, focus_attr=self.focus_attr)
- if str != '':
+ if s != '':
w = urwid.Columns([('fixed', len(s), self.label), self.cbox],
dividechars=1)
self.overlay = self.ComboSpace(self.list, parent, ui, index,
--end_of_patch--
`str` is a built-in class and comparing that with '' does not make sense.
I assume that the intention here was to compare the output from
`self.label.get_text()` with ''.
Please do let me know if I can help in any way to get it merged upstream or in
Debian.
Regards,
Wasif Malik
-- System Information:
Debian Release: buster/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 4.15.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages wicd-curses depends on:
ii python 2.7.14-4
ii python-urwid 2.0.1-2
ii wicd-daemon 1.7.4+tb2-5
Versions of packages wicd-curses recommends:
ii sudo 1.8.21p2-3
wicd-curses suggests no packages.
Versions of packages wicd-daemon depends on:
ii adduser 3.117
ii dbus 1.12.6-2
ii debconf 1.5.66
ii iputils-ping 3:20161105-1
ii isc-dhcp-client 4.3.5-4
ii lsb-base 9.20170808
ii psmisc 23.1-1
ii python 2.7.14-4
ii python-dbus 1.2.6-1
ii python-gobject 3.28.1-1
ii python-wicd 1.7.4+tb2-5
ii wireless-tools 30~pre9-12+b1
ii wpasupplicant 2:2.6-15
Versions of packages wicd-daemon recommends:
ii rfkill 2.31.1-0.5
Versions of packages wicd-daemon suggests:
pn pm-utils <none>
Versions of packages python-wicd depends on:
ii net-tools 1.60+git20161116.90da8a0-2
ii python 2.7.14-4
Versions of packages python-wicd suggests:
ii ethtool 1:4.15-1
ii iproute2 4.15.0-3
-- debconf information excluded
